Skip to content

Reinstate XDG_CACHE_HOME abspath check in tools/bazel*#47174

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/reinstate-xdg-cache-home-checks
Mar 3, 2026
Merged

Reinstate XDG_CACHE_HOME abspath check in tools/bazel*#47174
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/reinstate-xdg-cache-home-checks

Conversation

@rdesgroppes
Copy link
Contributor

@rdesgroppes rdesgroppes commented Mar 2, 2026

What does this PR do?

Very partially restores #47007, which was fully reverted in #47083 due to #incident-50242:

  • only the absolute-path validation on XDG_CACHE_HOME is reinstated,
  • in particular, the GOCACHE wiring that caused the incident is left out.

Motivation

A relative XDG_CACHE_HOME is silently accepted by the existing directory-existence check and would be used as-is, leading to cache misses or wrong paths depending on the working directory (see #47007)..

What does this PR do?
Partially restores #47007, which was fully reverted in #47083 due to
#incident-50242: only the absolute-path validation on XDG_CACHE_HOME is
reinstated.
In particular, the GOCACHE wiring that caused the incident is left out.

Motivation
A relative XDG_CACHE_HOME is silently accepted by the existing
directory-existence check and would be used as-is, leading to
cache misses or wrong paths depending on the working directory.
@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 2, 2026
@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-build labels Mar 2, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 2, 2026
@rdesgroppes rdesgroppes marked this pull request as ready for review March 2, 2026 16:10
@rdesgroppes rdesgroppes requested a review from a team as a code owner March 2, 2026 16:10
@JSGette
Copy link
Contributor

JSGette commented Mar 2, 2026

leading to cache misses or wrong paths depending on the working directory

This is very bad... there should be absolutely no dependency on a path

@agent-platform-auto-pr
Copy link
Contributor

Files inventory check summary

File checks results against ancestor 4db738ee:

Results for datadog-agent_7.78.0~devel.git.221.ade0d9b.pipeline.99778721-1_amd64.deb:

No change detected

@rdesgroppes
Copy link
Contributor Author

leading to cache misses or wrong paths depending on the working directory

This is very bad... there should be absolutely no dependency on a path

Maybe the way I turned the sentence is misleading?
I meant that mistakenly setting XDG_CACHE_HOME=some/path instead of /some/path would lead bazel (and XDG-compliant tools) to use different cache paths depending on the current working directory (and current drive on Windows) when run.
The said path doesn't participate in the cache key, only in the cache location.

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 2b9a70f into main Mar 3, 2026
297 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/reinstate-xdg-cache-home-checks branch March 3, 2026 09:38
@github-actions github-actions bot added this to the 7.78.0 milestone Mar 3, 2026
@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Mar 3, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9f2ca80c-c1ac-4078-b45c-2a7320b2700e

Baseline: 2e9eebe
Comparison: 2b9a70f
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -1.08 [-4.19, +2.03] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +1.31 [+1.10, +1.52] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.48 [+0.41, +0.55] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.29 [+0.24, +0.35] 1 Logs
file_tree memory utilization +0.29 [+0.24, +0.34] 1 Logs
otlp_ingest_logs memory utilization +0.25 [+0.16, +0.35] 1 Logs
quality_gate_idle memory utilization +0.25 [+0.21, +0.29] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.20 [-0.03, +0.42] 1 Logs
ddot_logs memory utilization +0.11 [+0.06, +0.16] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.09 [-0.05, +0.23] 1 Logs
otlp_ingest_metrics memory utilization +0.05 [-0.11, +0.21] 1 Logs
ddot_metrics_sum_delta memory utilization +0.04 [-0.13, +0.20] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.40, +0.42] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.09, +0.09] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.13, +0.12] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.46, +0.45] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.11] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.04 [-0.09, +0.01] 1 Logs
quality_gate_idle_all_features memory utilization -0.05 [-0.09, -0.02] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput -0.07 [-0.45, +0.32] 1 Logs
docker_containers_memory memory utilization -0.14 [-0.22, -0.07] 1 Logs
ddot_metrics memory utilization -0.42 [-0.59, -0.24] 1 Logs
docker_containers_cpu % cpu utilization -1.08 [-4.19, +2.03] 1 Logs
quality_gate_logs % cpu utilization -1.39 [-2.84, +0.05] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants