fuse: {io-uring} Prefer the current core over mapping#95
Closed
bsbernd wants to merge 1 commit intoredfs-rhel9_4-427.42.1from
Closed
fuse: {io-uring} Prefer the current core over mapping#95bsbernd wants to merge 1 commit intoredfs-rhel9_4-427.42.1from
bsbernd wants to merge 1 commit intoredfs-rhel9_4-427.42.1from
Conversation
Mapping might point to a totally different core due to
random assignment. For performance using the current
core might be beneficial
Example (with core binding)
unpatched WRITE: bw=841MiB/s
patched WRITE: bw=1363MiB/s
With
fio --name=test --ioengine=psync --direct=1 \
--rw=write --bs=1M --iodepth=1 --numjobs=1 \
--filename_format=/redfs/testfile.\$jobnum --size=100G \
--thread --create_on_open=1 --runtime=30s --cpus_allowed=1
In order to get the good number `--cpus_allowed=1` is needed.
This could be improved by a future change that avoids
cpu migration in fuse_request_end() on wake_up() call.
(cherry picked from commit 32e0073)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mapping might point to a totally different core due to random assignment. For performance using the current core might be beneficial
Example (with core binding)
unpatched WRITE: bw=841MiB/s
patched WRITE: bw=1363MiB/s
With
fio --name=test --ioengine=psync --direct=1
--rw=write --bs=1M --iodepth=1 --numjobs=1
--filename_format=/redfs/testfile.$jobnum --size=100G
--thread --create_on_open=1 --runtime=30s --cpus_allowed=1
In order to get the good number
--cpus_allowed=1is needed. This could be improved by a future change that avoids cpu migration in fuse_request_end() on wake_up() call.(cherry picked from commit 32e0073)