Ensure ifupdown2 runtime directory always exists (and debhelper 13 update)#282
Open
OlivierB wants to merge 4 commits intoCumulusNetworks:masterfrom
Open
Ensure ifupdown2 runtime directory always exists (and debhelper 13 update)#282OlivierB wants to merge 4 commits intoCumulusNetworks:masterfrom
OlivierB wants to merge 4 commits intoCumulusNetworks:masterfrom
Conversation
added 4 commits
November 10, 2023 20:09
The /run/network directory is used by ifupdown2 for locks and state files. This directory is created at service startup (networking). But if we want, for example, to use ifquery before network start, it fails. We can ensure that /run/network directory is always present with systemd-tmpfiles. We could do it with systemd RuntimeDirectory in the networking service, but it does not seem to be the right method with the standalone mode. Like /run/network, we can move /etc/network/run symlink creation in ifupdown2 tmpfiles
and /etc/network/run directory symlink. We no longer need to worry about the existence of this directory. The system handles the creation.
a70639f to
f7a3270
Compare
Author
|
Hello, I have split system configuration and codebase modification for the /run/network directory. The last commit on the codebase update is a very bad idea if ifupdown2 is built for non Debian system. I wait for your decision to known if we can keep it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /run/network directory is used by ifupdown2 for locks and state files.
This directory is created at service startup (networking). But if we want, for
example, to use ifquery before network start, it fails.
We can ensure that /run/network directory is always present with systemd-tmpfiles.
We could do it with systemd RuntimeDirectory in the networking service, but it
does not seem to be the right method with the standalone mode.
Preliminary work : Debhelper update.