feat: add no-unrestricted-loop-in-serverless lint rule#56
Open
danielchen0 wants to merge 3 commits intomainfrom
Open
feat: add no-unrestricted-loop-in-serverless lint rule#56danielchen0 wants to merge 3 commits intomainfrom
danielchen0 wants to merge 3 commits intomainfrom
Conversation
Detects unbounded loops (while(true), for(;;), while(1)) without break/return in the loop body, which cause Vercel 300s timeouts in serverless functions. Smart about nested loops and nested function returns. 21K+ timeouts/week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no-unrestricted-loop-in-serverlessrule that detects unbounded loops (while(true),for(;;),while(1)) without abreakorreturnin the loop bodybreakinside nested loops/switches, orreturninside nested arrow functions (e.g..map()callbacks)backendonlyTest plan
while (true) { await fetchData(); }(no break)for (;;) { await poll(); }(no break)while (1) { doWork(); }(no break)while (true) { if (done) break; }while (true) { if (done) return data; }for (let i = 0; i < 100; i++) { ... }while (count < 10) { ... }while (true) { for (...) { break; } }(break in nested loop)while (true) { data.map(x => { return x; }) }(return in nested fn)