chore(medcat-plugin-embedding-linker): CU-869c36ruk Separate embedding linker to its own project #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tomolopolis
approved these changes
Feb 11, 2026
Member
tomolopolis
left a comment
tomolopolis
left a comment
There was a problem hiding this comment.
lgtm - okay to consolidate the new gha workflows?
Member
There was a problem hiding this comment.
@alhendrickson - recently merged all the trainer workflows into one with final pushes of images / libs etc. predicated on a tagged build. Saves the extra workflow? We should likely do this for all the dirs?
https://github.com/CogStack/cogstack-nlp/blob/main/.github/workflows/medcat-trainer_ci.yml
|
|
||
| ## License | ||
|
|
||
| [Your license here] |
Member
There was a problem hiding this comment.
remove this block or reference the parent licence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates embedding linker to its own project that will be released on PyPI (as
medcat-embedding-linker).It should have migrated all the parts that were using this within the core library.
Also comes with some basic workflows (linting, typing, tests).
Made a change to the core lib as well to make typing explicitly defined (long overdue!).