Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades the project’s build platform to Gradle 9 / AGP 9 and refreshes dependency versions, alongside small updates to UI utilities to align with newer Compose/adaptive APIs.
Changes:
- Bump Gradle wrapper to 9.3.1 and add Foojay toolchain resolver convention plugin.
- Update version catalog (AGP/Kotlin/Compose/etc.), add
androidx.concurrent:futuresdeps, and adjust build configuration. - Update UI utilities: make
ObserveAsEventsaccept a suspend handler; reworkDeviceConfigurationto use adaptive window sizing and add helper properties.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
settings.gradle.kts |
Adds Foojay toolchain resolver convention plugin for toolchain provisioning. |
gradle/wrapper/gradle-wrapper.properties |
Updates wrapper to Gradle 9.3.1. |
gradle/libs.versions.toml |
Major dependency/plugin version bumps; adds concurrent-futures libs; updates Detekt plugin id. |
gradle.properties |
Adds/adjusts Android/AGP-related Gradle properties for the migration. |
app/.../ObserveAsEvents.kt |
Changes event callback to suspend and updates KDoc accordingly. |
app/.../DeviceConfiguration.kt |
Introduces adaptive-based configuration lookup and new enum helpers; updates classification logic. |
app/build.gradle.kts |
Refactors Android/Detekt/Kotlin/Room configuration blocks and updates dependencies for new libs. |
Comments suppressed due to low confidence (1)
app/build.gradle.kts:10
- The module no longer applies the Kotlin Android plugin. With Kotlin sources under
app/src/main/...and a top-levelkotlin { compilerOptions { ... } }block below, this is very likely to break configuration/compilation because thekotlinextension and Android/Kotlin compile tasks are provided byorg.jetbrains.kotlin.android. Re-addalias(libs.plugins.kotlin.android)(or otherwise apply the Kotlin Android plugin) in this module.
plugins {
alias(libs.plugins.android.application)
alias(libs.plugins.detekt)
alias(libs.plugins.junit5)
alias(libs.plugins.kotlin.compose)
alias(libs.plugins.kotlin.serialization)
alias(libs.plugins.ksp)
alias(libs.plugins.room)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...src/main/java/com/codermp/composeandroidtemplate/core/presentation/ui/DeviceConfiguration.kt
Show resolved
Hide resolved
...src/main/java/com/codermp/composeandroidtemplate/core/presentation/ui/DeviceConfiguration.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Description
PR adds in the platform migration to Gradle 9 and adds some improvements to pre-existing utility classes.
📄 Motivation and Context
PR is required to modernize the template to keep it current and functional
🧪 How Has This Been Tested?
📷 Screenshots (if appropriate)
📦 Types of changes
✅ Checklist