London|25-SDC-NOV| FATMA DEGIRMENCI | Sprint 5|Prep exercise Python #315
Conversation
…update find_possible_laptops
fatmaevin
force-pushed
the
prep-exercise
branch
from
a0f40c5 to
0cc0f04
Compare
fatmaevin
added
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
Remember to include a summary of the changes in the pull request text.
There was a problem hiding this comment.
Can you explain the difference between methods and functions, and any benefits/disadvantages?
| def print_family_tree(person: Person) -> None: | ||
| print(person.name) | ||
| for child in person.children: | ||
| print(f"- {child.name} ({child.age})") |
There was a problem hiding this comment.
Can you figure out how to recursively print a full family tree, like grandchildren as well?
There was a problem hiding this comment.
Can you explain why the errors in this file occur?
|
|
||
| try: | ||
| age = int(age_input) | ||
| except ValueError: |
There was a problem hiding this comment.
When taking input, consider the user experience. Right now it asks or all the input and if there are problems it quits and you have to try again. Could you improve this?
LonMcGregor
added
Reviewed
2 participants
Self checklist