London | SDC-Nov-2025| Ikenna Agulobi | Sprint 5| Prep exercise python #312
Conversation
…t it does report and error
This comment has been minimized.
This comment has been minimized.
ike-agu
changed the title
ike-agu
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Very good work on these tasks, there are some areas where you could improve further
There was a problem hiding this comment.
Has this file passed the mypy type checker?
There was a problem hiding this comment.
I've added type annotations and fix the bugs to ensure the file passes mypy type checker.
There was a problem hiding this comment.
Can you describe the difference and any dis/advantage of using a class method vs a function?
There was a problem hiding this comment.
A function is standalone code with its own behaviour, while a class method is code whose behaviour belongs to an object or class and operates on its internal state.
------Advantages of using methods: ---------
• Ease of documentation and discoverability
Attaching behaviour to a type makes it easier to find and understand all operations related to that type. For example, methods on str or Person group related functionality together, rather than scattering it across separate functions.
• Encapsulation
Methods hide the internal representation of a type. If the implementation of Person changes (e.g. storing a date of birth instead of an age), the code that uses Person does not need to change, and it is clearer which methods may need updating internally.
• Improved readability
Methods read like natural language and make code easier to understand e.g is_adult(Imran)
prep_exercise/6_generics.py
Outdated
| def print_family_tree(person: Person) -> None: | ||
| print(person.name) | ||
| for child in person.children: | ||
| print(f"- {child.name} ({child.age})") |
There was a problem hiding this comment.
Can this print grandchildren recursively?
There was a problem hiding this comment.
I've now fix my code and family tree prints children recursively. Thank you for your review and feedback
prep_exercise/8_enums.py
Outdated
| if best_os != person.preferred_operating_system and best_count > preferred_count: | ||
| print( | ||
| f"If you are willing to accept {best_os.value} instead," | ||
| f"You're more likely to get a laptop. {best_count} available)." |
There was a problem hiding this comment.
I think you have an extra bracket here you dont need
There was a problem hiding this comment.
Thanks for catching that. I've now fixed the output message formatting by removing the extra parenthesis.
LonMcGregor
added
Reviewed
|
@LonMcGregor ,Thank you for taking the time to review my PR and providing helpful feedbacks. I'v fixed the changes you pointed out. When you will be available, could you take another look. |
ike-agu
added
the
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on these tasks, it is complete now
LonMcGregor
added
Complete
|
@LonMcGregor Thank you for taking the time to review my PR. |
2 participants
Learners, PR Template
Self checklist
Changelist
This PR contains my sprint 5 prep exercises: