London | SDC-Nov-25 | Pezhman Azizi | Sprint 4 | Implement shell Tools In Python #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pezhman-Azizi
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jan 21, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
Very nicely formatted PR text!
There was a problem hiding this comment.
This script works well, but you may want to take another look at the readme for this task, you seem to be missing some features
| if args.count_words: | ||
| totals_output.append(str(totals[1])) | ||
| if args.count_bytes: | ||
| totals_output.append(str(totals[2])) |
There was a problem hiding this comment.
Can you see the repetition in the structure of the output part of the script? can you think of any way to improve this?
| output_parts.extend([str(lines), str(words), str(bytes_)]) | ||
| else: | ||
| if args.count_lines: | ||
| output_parts.append(str(lines)) |
There was a problem hiding this comment.
When multiple files are given, does the output look neat enough? is there any way you could improve how it looks?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR adds Python implementations of the three shell tools required for the sprint: cat, ls, and wc.
Each tool is implemented in its own commit for clarity and easier review.
This PR adds Python implementations of the three shell tools required for the sprint:
cat,ls, andwc.Each tool is implemented in its own commit for clarity and easier review.
🔹 What's Included
cat.py
argparsecatls.py
-1(one entry per line)-a(show hidden files)os.listdir()and simple filteringwc.py
-l,-w,-ctotallineargparseand UTF-8 byte counting🔹 Notes
cat,ls,wc)