-
-
Notifications
You must be signed in to change notification settings - Fork 402
Manchester | 26-ITP-Sep | khalid bih | Sprint 1 | Wireframe #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jenny-alexander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @khalidbih - nice job getting your PR created with your exercise submission! Your wireframe webpage looks very good. I see a few places to improve upon.
- Can you run your webpage through https://validator.w3.org/? I see an error that should be fixed.
- Can you please replace the
placeholder.svgimage with an image that is related to the article? - Can you review the footer styling? Currently is overlapping on the 'Read more' buttons and cutting them off a little bit.
Thank you for reviewing my PR. I will make improvements to my wireframe coursework following the feedback you provided. |


Self checklist
Changelist
I created the Wireframe project page with three articles explaining README, Wireframe, and Git branches. Footer is fixed, and CSS is linked.