London | 26-ITP-Jan | Damian Dunkley | Sprint 1 | Feature/Wireframe #1019

DamianDL · 2026-01-23T13:04:04Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

New PR to effect changes to Wireframe;

removed old up branch,
removed old Index file
updated CSS to centre initial header.
Will close initial request London | 26-ITP-Jan | Damian Dunkley | Sprint 1 | Feature/Wireframe #958

Questions

Am I correct to remove the image and just have the text boxes?

netlify · 2026-01-23T13:04:10Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`7254063`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/697892e09e752100081dc8ef
😎 Deploy Preview	https://deploy-preview-1019--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

added code deleted by mistake

jenny-alexander

@DamianDL - Your exercise submission is done very well 👏 Nice job.

I noticed that you removed the 3 <img> tags from your index file. Each article should have a related image.
I also noticed that you have files related to the Form-Controls exercise in this PR. Can you ensure that this PR only has files related to the Wireframe exercise?

jenny-alexander · 2026-01-24T00:14:11Z

Wireframe/index.html

      <article>
-        <img src="placeholder.svg" alt="" />
-        <h2>Title</h2>
+


<img src="placeholder.svg" alt="" /> should not be removed from the file. Can you add it back and add an image that relates to the article? Don't forget about alt text. https://www.w3schools.com/tags/att_img_alt.asp

💡 Each article should have an image.

jenny-alexander · 2026-01-24T00:17:08Z

Wireframe/index.html

+          the user interface, plan content placement, and ensure that the user
+          experience is intuitive and effective.
+        </p>
+        <a href="https://www.productplan.com/glossary/wireframe/">Read more about Wireframes</a>


The wireframe button says 'Read more'. Your buttons should be named the same thing! Try to follow the wireframe as much as possible. 🙂

jenny-alexander · 2026-01-24T00:17:11Z

Wireframe/index.html

+          branch when ready.
        </p>
-        <a href="">Read more</a>
+        <a href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches">Read more about Git branches</a>


The wireframe button says 'Read more'. Your buttons should be named the same thing! Try to follow the wireframe as much as possible. 🙂

jenny-alexander · 2026-01-24T00:18:00Z

Wireframe/index.html

+
+        <h2>What is the Purpose of a Readme File</h2>
+        <p>
+          >A readme file serves as a guide for users and developers, providing


The > character appears to be a typo here.

jenny-alexander

@DamianDL - your webpage is almost complete. There are few more changes to make in order for it to meet exercise requirements though.

Your alt text for the 3 images has a small mistake in it.
There should be opening quotes (") at the beginning of the alt text and closing quotes (") at the end of it.
Here is an example: <img src="dog.jpg" alt="Golden retriever puppy playing with a tennis ball">

jenny-alexander · 2026-01-25T03:14:05Z

Wireframe/index.html

+      <h1>Wireframe Webcode Assignment</h1>
      <p>
-        This is the default, provided code and no changes have been made yet.
+       This is the initial DRAFT version of this page. <!--First line updated to reflect draft status-->


Instead of saying that your webpage is a draft of the page, can you think of a sentence that summarizes your webpage?

jenny-alexander · 2026-01-25T03:17:35Z

Wireframe/index.html

+        <a href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches">Read more</a>
      </article>
    </main>
    <footer>


Can you think of any useful information you can add to your footer instead of the default text?
Other trainees have included:

name

link to CYF socials

your email

Any of these 👆 will be an improvement to the default text. 🙂

Thanks Jenny, updates to initial page description, alt text for three pictures and Footer. Thanks for reviewing yesterday.

jenny-alexander · 2026-01-25T03:21:12Z

Wireframe/index.html

+        <a href="https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes">Read more</a>
+      </article>
+      <article>
+        <img src="https://www.productplan.com/wp-content/uploads/2019/03/wireframe-1024x576.png" alt="Wireframe example, Headline "What is the Purpose of a Wireframe"" />


Can you check the 'What is the purpose of a wireframe' image? Currently it shows a broken link.

…ption and footer

DamianDL · 2026-01-26T18:26:05Z

Please review?

Wireframe image updated
Page description updated, details added and "draft" removed.
Footer updated with my name and reference to Course.
Thanks

jenny-alexander · 2026-01-26T20:45:24Z

Please review?

Wireframe image updated

Page description updated, details added and "draft" removed.

Footer updated with my name and reference to Course.
Thanks

@DamianDL Your changes look great! The only thing left to modify is your footer.

I can't read the text when I start to scroll down the page.
Ensure that the footer spans across the entire width of the page (or close to it).

…ound using the paper default

DamianDL · 2026-01-27T10:37:18Z

Thanks Jenny,
Changes made to CSS to format the footer, with background the same as the rest of the page and fix to the bottom of the page.

jenny-alexander · 2026-01-27T13:25:18Z

Thanks Jenny, Changes made to CSS to format the footer, with background the same as the rest of the page and fix to the bottom of the page.

Can you check the footer again? It is no longer fixed in place.

DamianDL added 5 commits January 15, 2026 12:59

Update text to answer three questions in 3 articles, with links.

a0943dd

Changes to page formatting into Wireframe template

3e10354

Update to Forms for Sprint 2 exercise

73b1697

centre header text

43967f2

refactor: cleaning up code

f7fb669

This comment has been minimized.

Sign in to view

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

This comment has been minimized.

Sign in to view

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

This comment has been minimized.

Sign in to view

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

This comment has been minimized.

Sign in to view

Delete Code in Form-Controls

a4853b6

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026

DamianDL and others added 2 commits January 23, 2026 16:54

added code deleted by mistake

f054232

Merge pull request #1 from DamianDL/feature/wireframe

19a6c3b

added code deleted by mistake

jenny-alexander self-requested a review January 23, 2026 20:42

jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 23, 2026

This comment has been minimized.

Sign in to view

jenny-alexander reviewed Jan 24, 2026

View reviewed changes

jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 24, 2026

This comment has been minimized.

Sign in to view

DamianDL added 3 commits January 24, 2026 16:14

revert accidental change

0ef0bd2

Update to text and images

dc22d6e

Update to text and images

13c08a2

jenny-alexander reviewed Jan 25, 2026

View reviewed changes

Updated formatting of image alt descriptions and text for page descri…

9118e2e

…ption and footer

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 26, 2026

jenny-alexander removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 26, 2026

update to CSS to set the footer to the bottom of the page on a backgr…

7254063

…ound using the paper default

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 27, 2026

Uh oh!

London | 26-ITP-Jan | Damian Dunkley | Sprint 1 | Feature/Wireframe #1019

Are you sure you want to change the base?

London | 26-ITP-Jan | Damian Dunkley | Sprint 1 | Feature/Wireframe #1019

Conversation

DamianDL commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

netlify bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jenny-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

jenny-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

DamianDL Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

DamianDL commented Jan 26, 2026

Uh oh!

jenny-alexander commented Jan 26, 2026

Uh oh!

DamianDL commented Jan 27, 2026

Uh oh!

jenny-alexander commented Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DamianDL commented Jan 23, 2026 •

edited

Loading

netlify bot commented Jan 23, 2026 •

edited

Loading

jenny-alexander Jan 24, 2026 •

edited

Loading