-
-
Notifications
You must be signed in to change notification settings - Fork 21
West Midlands | July-SDC | Gabriel Deng |Sprint 4 | Laptop-allocation #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
4 similar comments
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Decomposition - Sprint 4) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start at this task, and it will work for the interactive method you're using. But if you re-read the spec in the task (https://sdc.codeyourfuture.io/decomposition/sprints/4/backlog/#04-implement-laptop-allocation) It's asking for a specific method that takes a list of possible laptops, a list of possible people, and then returns a matching for all of them.
Can you extend your code to meet that criteria?
|
Hey @LonMcGregor, thanks for clearing that up for me. I will try to adapt
my current implementation to meet that criteria.
…On Tue, 28 Oct 2025 at 15:15, LonMcGregor ***@***.***> wrote:
***@***.**** commented on this pull request.
This is a good start at this task, and it will work for the interactive
method you're using. But if you re-read the spec in the task (
https://sdc.codeyourfuture.io/decomposition/sprints/4/backlog/#04-implement-laptop-allocation)
It's asking for a specific method that takes a list of possible laptops, a
list of possible people, and then returns a matching for all of them.
Can you extend your code to meet that criteria?
—
Reply to this email directly, view it on GitHub
<#38 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BC3JQE6W22B2EQAS5FAYLOD3Z6B7RAVCNFSM6AAAAACJVO2WI2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGOBZGMYDENBQGY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
com>
|
Learners, PR Template
Self checklist