London | 25-SDC-July | Mikiyas Gebremichael | Sprint 4 | Implement laptop allocation #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikiyas-STP
added
Needs Review
LonMcGregor
reviewed
Oct 28, 2025
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Hi, good implementation, but I've left a comment where you might want to think about the efficiency of your solution.
| for person in people: | ||
| for laptop in laptops: | ||
| if laptop.operating_system in person.preferred_operating_system: | ||
| sadness = person.preferred_operating_system.index(laptop.operating_system) |
There was a problem hiding this comment.
One thing to be aware of is efficiency of your solution. This works, but think about how long it will take to complete this. You have an example with about 3 people and laptops. How many times would this need to run if that increased?
Something to think about is when you know you have a suitable answer. If you find a matching laptop, do you need to keep checking every other one?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implement laptop allocation
Questions
none