London | 25-SDC-July | Mikiyas Gebremichael | Sprint 4 | Prep exercises #35
Conversation
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Mikiyas-STP
added
📅 Sprint 4
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
2 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
| print(eliza.name) | ||
| print(eliza.address) | ||
|
|
||
| #imran.address and eliza.address is not valid attribute |
There was a problem hiding this comment.
Could you suggest a change that would fix this error?
| @dataclass(frozen=True) | ||
| class Person: | ||
| name: str | ||
| age: int |
There was a problem hiding this comment.
Can you solve this in a way that it always prints the current age, rather than hard-coding a specific age?
| #Traceback (most recent call last): | ||
| # File "/Users/Module-Decomposition/prep_exercises/exercise9inheritance.py", line 34, in <module> | ||
| # print(person2.get_full_name()) | ||
| #AttributeError: 'Parent' object has no attribute 'get_full_name' No newline at end of file |
There was a problem hiding this comment.
Can you explain what this error means?
LonMcGregor
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
decomposition sprint4 prep exercise
Questions
no question