Skip to content

London | 25-SDC-July | Fatma Arslantas | Sprint 2 | Improve code with precomputing #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AFatmaa wants to merge 2 commits into
base: main
Choose a base branch
from
Open

London | 25-SDC-July | Fatma Arslantas | Sprint 2 | Improve code with precomputing #77

AFatmaa wants to merge 2 commits into from

Conversation

@AFatmaa
Copy link

@AFatmaa AFatmaa commented Jan 17, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I optimised common_prefix and count_letters using Precomputing techniques.

  • Common Prefix:
    • Old: Compared every string with every other string.
    • New: I sorted the list first. Similar strings became neighbours. I only compared neighbours.
  • Count Letters:
    • Old: Scanned the huge string repeatedly for every uppercase letter.
    • New: I created a Set of all characters first. Checking if a lowercase letter exists is now instant.

Questions

I don’t have any questions, thank you!

@AFatmaa AFatmaa added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 17, 2026
@AFatmaa AFatmaa mentioned this pull request Jan 17, 2026
Open
cjyuan
cjyuan reviewed Jan 23, 2026
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you know your solutions are better?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AFatmaa @cjyuan