generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 14
London | 25-SDC-July | Fatma Arslantas | Sprint 2 | Improve code with caches #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AFatmaa
wants to merge
2
commits into
CodeYourFuture:main
Choose a base branch
from
AFatmaa:feat/sprint-2-improve-with-caches
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,17 @@ | ||
| # Create a dictionary to use as our "Notepad" (Cache) | ||
| memo = {} | ||
|
|
||
| def fibonacci(n): | ||
| # Check if we already calculated this number | ||
| if n in memo: | ||
| return memo[n] | ||
|
|
||
| if n <= 1: | ||
| return n | ||
| return fibonacci(n - 1) + fibonacci(n - 2) | ||
|
|
||
| result = fibonacci(n - 1) + fibonacci(n - 2) | ||
|
|
||
| # Save the result in our Notepad before returning | ||
| memo[n] = result | ||
|
|
||
| return result |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,38 @@ | ||
| from typing import List | ||
|
|
||
| cache = {} | ||
|
|
||
| def ways_to_make_change(total: int) -> int: | ||
| """ | ||
| Given access to coins with the values 1, 2, 5, 10, 20, 50, 100, 200, returns a count of all of the ways to make the passed total value. | ||
|
|
||
| For instance, there are two ways to make a value of 3: with 3x 1 coins, or with 1x 1 coin and 1x 2 coin. | ||
| """ | ||
| # Clear cache before starting new calculation | ||
| cache.clear() | ||
| return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1]) | ||
|
|
||
|
|
||
| def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | ||
| """ | ||
| Helper function for ways_to_make_change to avoid exposing the coins parameter to callers. | ||
| """ | ||
| # We use tuple(coins) because lists cannot be keys. | ||
| key = (total, tuple(coins)) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From line 45, we know We could further improve the performance if we can
I don't think this exercise expects trainees to optimize the code to this level. So change is optional. |
||
|
|
||
| if key in cache: | ||
| return cache[key] | ||
|
|
||
| if total == 0 or len(coins) == 0: | ||
| return 0 | ||
|
|
||
| # Check if only one coin type remains | ||
| if len(coins) == 1: | ||
| if total % coins[0] == 0: | ||
| return 1 | ||
| else: | ||
| return 0 | ||
|
|
||
| ways = 0 | ||
| for coin_index in range(len(coins)): | ||
| coin = coins[coin_index] | ||
|
|
@@ -29,4 +45,7 @@ def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | |
| intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:]) | ||
| ways += intermediate | ||
| count_of_coin += 1 | ||
|
|
||
| # Store result in cache | ||
| cache[key] = ways | ||
| return ways | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to make
cachelocal insideways_to_make_change(), and defineways_to_make_change_helper()as an inner function insideways_to_make_change().Since that's not the purpose of this exercise, change is optional.