Conversation
jordangov
left a comment
jordangov
left a comment
There was a problem hiding this comment.
Thanks again for the contribution @milovanderlinden! Since this is your first submission, can you please add your name to the contributors list? This also means that you are agreeing to the terms of the Developer Certificate of Origin (DCO) that is linked on that page. Let us know if you have any questions.
src/_layouts/project.html
Outdated
| <p> | ||
| {{ page.description }} | ||
| </p> | ||
| <p>Status: {{ page.status }}</p> |
There was a problem hiding this comment.
Hmm, thinking this might be a <ul>? They're not really paragraphs :)
There was a problem hiding this comment.
I am open to all suggestions. If you are sure you want me to change it to
- I will.
src/_layouts/project.html
Outdated
| <p>Organization: {{ page.organization }}</p> | ||
| <p>Source: <a href="{{ page.repositoryURL }}">{{ page.repositoryURL }}</a></p> | ||
| <p>License: <a href="{{ page.permissions.licenses[0].URL }}">{{ page.permissions.licenses[0].name }}</a></p> | ||
| <p>Contact: <a href="mailto://{{ page.contact.email }}">{% if page.contact.name %} {{ page.contact.name }} {% else %} email {% endif %}</a></p> |
There was a problem hiding this comment.
Should this be page.contact.email in the displayed portion of the link (when there is not contact name)?
There was a problem hiding this comment.
There are situations in the code.json file where there is an email, but not a name. But I will enhance this with a check for email too.
There was a problem hiding this comment.
Enhanced it with a couple of checks as there is some pollution in the data
There was a problem hiding this comment.
Sorry, I meant at the end... it says {% if page.contact.name %} {{ page.contact.name }} {% else %} email {% endif %} and my question was, at the end there, should that be page.contact.email? Like this:
{% if page.contact.name %} {{ page.contact.name }} {% else %} {{page.contact.email}} {% endif %}
Just a thought. I guess I'm open to either just the word "email" or the actual email...
| @@ -0,0 +1,13 @@ | |||
| --- | |||
| title: Projects | |||
There was a problem hiding this comment.
I think this is a good start, but I'd like to see a bit more style and layout on this page before we push it. Maybe add a couple more details to this list? Perhaps we could steal the layout/styles of the Code.gov browser projects page?
| layout: null | ||
| permalink: code.json | ||
| --- | ||
| {{ site.data.code | jsonify | strip_html}} No newline at end of file |
There was a problem hiding this comment.
This is a possible solution to not having two code.json files created through two different generators.
|
@david-saeger Why did we close this PR? Do you think it is not viable as an option to resolve the user-friendly project inventory? |
3 participants
Issue: #241
Approach
src\_plugins\code_json_generate_oncesrc\_plugins\data_page_generator.rbtaken from https://github.com/avillafiorita/jekyll-datapage_gen this script will generate individual pages per projectPlease review