Conversation
dburkhart07
requested changes
Feb 4, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Mostly just some small nits. This looks amazing for a first pass!
| path: '/pantry-dashboard/:pantryId', | ||
| element: ( | ||
| <Authenticator components={components}> | ||
| <ProtectedRoute> |
There was a problem hiding this comment.
Note for later: The pantry id loader I think makes u navigate to a 404 error instead (while still navigating to request-form/1). I think my role based auth backend may have fixed this, but once this get's merged in we should check to see if it still works. If not, we may need to adjust how the ProtectedRoute and loader interact with each other.
dburkhart07
requested changes
Feb 10, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
One small thing to investigate, but after that should be good!
dburkhart07
approved these changes
Feb 13, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Approving pending one small change. Remember to merge main in.
maxn990
requested changes
Feb 14, 2026
maxn990
reviewed
Feb 15, 2026
Member
maxn990
left a comment
maxn990
left a comment
There was a problem hiding this comment.
Nice Justin! One small thing otherwise looks awesome
maxn990
approved these changes
Feb 16, 2026
Comment on lines
+47
to
+50
| if (password.length < 8) { | ||
| alert('Password needs to be at least 8 characters'); | ||
| return; | ||
| } |
amywng
pushed a commit
that referenced
this pull request
Feb 17, 2026
* login page * signup page * forgot password flow * refactoring to use my login page instead of authenticator from amplify * refactoring to combine verification and new password modals * minor refactoring * prettier * minor refactoring * switching button color to ssf blue * minor refactoring * adding password requirement info and eye crossed out icon * changing password requirement text to be accurate * making all routes protected, refactoring password requirement visual * adding alert for password being 8 characters at least
amywng
pushed a commit
that referenced
this pull request
Feb 17, 2026
* login page * signup page * forgot password flow * refactoring to use my login page instead of authenticator from amplify * refactoring to combine verification and new password modals * minor refactoring * prettier * minor refactoring * switching button color to ssf blue * minor refactoring * adding password requirement info and eye crossed out icon * changing password requirement text to be accurate * making all routes protected, refactoring password requirement visual * adding alert for password being 8 characters at least
amywng
added a commit
that referenced
this pull request
Feb 17, 2026
* Updated auth * Tried fixing JWT Strategy * Updated auth * Finished general authentication for both frontend and backend pages * Final commit for this branch * Revisions made with Sam!!! * Full implementation of backend role-based auth * prettier * Fixed user flow to use a cognito id hardcoded into the database * prettier * Added requested changes * Added in decorator and guard for a bypass gaurd * Final commit * Resolved comments * Fixed addition of audience * Fixed bugs wth id loader * Final commit * Final commit * remove ids from routes * prettier * fix tests * fix form requests file * fix problems with merge * more cleanup * review comments * add exception propagation test * SSF-122 auth page frontend (#94) * login page * signup page * forgot password flow * refactoring to use my login page instead of authenticator from amplify * refactoring to combine verification and new password modals * minor refactoring * prettier * minor refactoring * switching button color to ssf blue * minor refactoring * adding password requirement info and eye crossed out icon * changing password requirement text to be accurate * making all routes protected, refactoring password requirement visual * adding alert for password being 8 characters at least * review comments * fix error * fix error * fix things from merge * clean up * fix yarnfile --------- Co-authored-by: Dalton Burkhart <daltonburkhart.75@gmail.com> Co-authored-by: Justin Wang <74576640+Juwang110@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-122
📝 Description
I refactored the application to move away from using the prebuilt Authenticator component to handle AWS cognito functionality with amplify. This allowed me to manually call amplify api functions so that the login/signup flow frontend could be customized to match the figma designs. I also fixed the css styling issue that the authenticator component was causing by removing its use.
I added 3 new frontend pages: /login, /signup, and /forgot-password. The forgot-password page features a modal that will change based on if you are on the stage of setting a new password, or the verification code stage.
✔️ Verification
I went through all the login flow testing signing in, up, forgetting and resetting my password etc. I made sure the frontend designs matched the figma as well.
🏕️ (Optional) Future Work / Notes
Note: the signup page has a button to navigate to the food manufacturer application. This is not currently in main but there is a pr up by Amy to implement the frontend for that application. I based the navigation route based on that but it currently wont work.
NOTE: I have some alerts in here for some error states, I understand theres a ticket to make these to chakra ones so to make everything uniform I didn't want to do those yet. If that gets in first I will update these alerts to match.