Open
Conversation
nourshoreibah
requested changes
Feb 14, 2026
Collaborator
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
Awesome work with the auth logic!! Just a couple of tweaks here
| "sourceMap": true | ||
| }, | ||
| "include": ["*.ts"], | ||
| "include": ["*.ts", "test/test-cognito.ts"], |
Collaborator
There was a problem hiding this comment.
Do we need this? I think *.ts catches it
| NX_DB_PORT=5432, | ||
|
|
||
| COGNITO_USER_POOL_ID=us-east-2_CxTueqe6g | ||
| COGNITO_CLIENT_ID=570i6ocj0882qu0ditm4vrr60f |
Collaborator
There was a problem hiding this comment.
Ideally we shouldn't be pushing these for security. You can put them in .env on your local and git will ignore them
| "@nestjs/typeorm": "^10.0.0", | ||
| "@types/pg": "^8.15.5", | ||
| "amazon-cognito-identity-js": "^6.3.5", | ||
| "aws-jwt-verify": "^5.1.1", |
Collaborator
There was a problem hiding this comment.
GHA failure seems to have something to do with this package, i'd check on it/compare to PRs that are passing these checks
|
|
||
| "@types/aws-lambda@^8.10.160": | ||
| version "8.10.160" | ||
| resolved "https://registry.npmjs.org/@types/aws-lambda/-/aws-lambda-8.10.160.tgz" |
Collaborator
There was a problem hiding this comment.
Ah it looks like you have 2 package managers. we us npm instead of yarn! might be causing the CI failure
Collaborator
There was a problem hiding this comment.
to be clear, we don't need this lock file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #107
📝 Description
Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.
Added authentication to the users lambda route to protect it from anyone accessing the endpoints.
Briefly list the changes made to the code:
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Provide screenshots of any new components, styling changes, or pages.
Tests ran after authorization was added:
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!