96 create GitHub actions sync type script definitions with database#108
Open
96 create GitHub actions sync type script definitions with database#108
Conversation
nourshoreibah
approved these changes
Feb 14, 2026
Collaborator
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
Just one comment about commit race conditions. Assuming you tested and this works, LGTM!
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Commit and push changes |
Collaborator
There was a problem hiding this comment.
One thing to be careful of here: Since we have many CI things that push changes, we need to be careful of race conditions. We should ideally have one bot that manages all the commiting/pushing, but for now, can you make the Terraform readme workflow wait for this one? (Thillai has a PR up for another workflow that waits for the terraform one)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes
📝 Description
Created a Github actions workflow that automatically updates the typescript definitions if there's any database schema changes. This occurs on pull requests when database related files are modified and uses kysely to regenerate the datatypes and copies it to db-types.d.ts in each of the lambdas.
Briefly list the changes made to the code:
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Provide screenshots of any new components, styling changes, or pages.
Used act to run the workflow in my command prompt to ensure it worked
🏕️ (Optional) Future Work / Notes
I want to make sure the workflow output is clear, so if you think there should be echo commands in certain places or if the summary needs more information, let me know!