Skip to content

266 dev improve error handling for notifications module#306

Open
camila-carrillo wants to merge 7 commits intomainfrom
266-dev---improve-error-handling-for-notifications-module
Open

266 dev improve error handling for notifications module#306
camila-carrillo wants to merge 7 commits intomainfrom
266-dev---improve-error-handling-for-notifications-module

Conversation

@camila-carrillo
Copy link
Contributor

ℹ️ Issue

Closes #296

📝 Description

Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.

Briefly list the changes made to the code:

  1. implemented forgot password and new login design (according to new frontend style guidelines)
  2. added forgot password route

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

ran localhost and ensured all changes looked good. tested on different window sizes.
Screenshot (65)

Screenshot (66)

Test Changes

n/a

🏕️ (Optional) Future Work / Notes

Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!

we currently still use the username variable although we only use email now. we could potentially change that

{/* Error Message */}
<div className="">
{failure && (
<div className="mb-6 bg-red-lighter text-red rounded-xl py-3 px-4 text-center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up removing bg-red-lighter and replaced it with bg-red-light if you could update the color here to bg-red-light that would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEV - Implement Login and Forgot Password Page Design

2 participants