[DO NOT REVIEW OR MERGE] Move pyrsistent serialization and hashing helpers to a new module.#2858
Open
[DO NOT REVIEW OR MERGE] Move pyrsistent serialization and hashing helpers to a new module.#2858
Conversation
…-organize the tests accordingly.
Contributor
|
I think you can do a lot better than this, seriously |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's an idea for re-organizing the serialization stuff so that I can e.g. use wire_encode from _diffing in #2839.
Unfortunately it's not quite enough.
Perhaps instead,
wire_decodeshould accept anacceptable_classesargument rather than having the globalSERIALIZABLE_CLASSESvariable.After all we'd never expect to find _diffing classes in the control service configuration which also uses the wire_encode format.
Needs more thought.