Fix UI hang when pressing Space in the main menu.

[YBronst]

Fix UI hang when pressing Space in the main menu.

Description

When pressing the space bar in the main menu, Clover's interface froze completely.

Type of change

• Bugfix
• New functionality
• Code improvements
• Documentation update

Checklist

• Tested my changes locally
• Added relevant comments to the code
• Updated the relevant documentation

Additional information

This bug was caused by an incompatibility XStringW OldOSName{OSName}; in GCC 15.2

[SergeySlice]

This is not a fix because there is no explanation.

[YBronst]

This is not a fix because there is no explanation.

The hang when using OldOSName occurred because if OSName contained invalid garbage (due to missing subString checks or memory issues), attempting to create a copy of this string or restore it would cause the UEFI memory manager to crash.

For now, I've temporarily disabled this and will try rewriting the XStringW class (via XStringAbstract) to use a consistent delete[] style of memory deletion, which eliminates conflicts with GCC 15.2's aggressive optimizations.
A self-assignment check (if (this == &S)) has been added, preventing crashes on accidental operations like str = str;.