Merged
Conversation
anoto-moniz
commented
Feb 6, 2026
| token = jwt.encode( | ||
| payload={'exp': expiration.timestamp()}, | ||
| key='garbage' | ||
| key='Actually_Triangle_Perhaps_Finally' |
Collaborator
Author
There was a problem hiding this comment.
The updated pyjwt was warning about this key being too short.
Collaborator
There was a problem hiding this comment.
Would it make sense to have this be a shared import, rather than a magic string that appears twice?
Collaborator
Author
There was a problem hiding this comment.
Probably. I'll include that adjustment on some other PR.
anoto-moniz
commented
Feb 6, 2026
| sphinx==7.1.2 | ||
| sphinx-rtd-theme==2.0.0 | ||
| sphinxcontrib-apidoc==0.4.0 | ||
| sphinx==8.1.3 |
Collaborator
Author
There was a problem hiding this comment.
Sphinx 9.0 requires 3.12+.
anoto-moniz
force-pushed
the
toml
branch
3 times, most recently
from
d45d281 to
c3ecc80
Compare
kroenlein
approved these changes
Feb 10, 2026
Collaborator
kroenlein
left a comment
kroenlein
left a comment
There was a problem hiding this comment.
Looks good and runs. I'm having some trouble forcing it to run tests against oldest supported, but I think that's a me-problem.
| token = jwt.encode( | ||
| payload={'exp': expiration.timestamp()}, | ||
| key='garbage' | ||
| key='Actually_Triangle_Perhaps_Finally' |
Collaborator
There was a problem hiding this comment.
Would it make sense to have this be a shared import, rather than a magic string that appears twice?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modeled after gemd-python's TOML.
PR Type:
Adherence to team decisions