Set default python version 3.9 and fix strenum problem#135
Open
Set default python version 3.9 and fix strenum problem#135
Conversation
jacomago
requested review from
anderslindho,
ralphlange,
shroffk,
simon-ess and
tynanford
Contributor
Author
|
I tried to get this check in the pre-commit, but adding all ruff lints wasn't enough, I had to add type checking... Which made the PR huge. So I'll stick with just this change for now. |
anderslindho
reviewed
Feb 6, 2026
jacomago
force-pushed
the
set-default-python-version-lower
branch
from
7dd8ea3 to
e3862b6
Compare
tynanford
reviewed
Feb 11, 2026
jacomago
force-pushed
the
set-default-python-version-lower
branch
from
e3862b6 to
2f39dc5
Compare
simon-ess
approved these changes
Feb 13, 2026
jacomago
force-pushed
the
set-default-python-version-lower
branch
from
dfbfa02 to
3f12593
Compare
Co-authored-by: anderslindho <44849690+anderslindho@users.noreply.github.com>
jacomago
force-pushed
the
set-default-python-version-lower
branch
from
3f12593 to
7368eb7
Compare
This should hopefully stop the flaky breakage in ci where 8080 is marked as in use.
|
Contributor
Author
|
I think this PR is fine now. The tests look like to do with the ioc container in the tests taking too long to build for some reason. So I will think about a separate PR for that. And I locally ran the tests and they passed. |
anderslindho
approved these changes
Feb 18, 2026
|
|
||
|
|
||
| def create_client_from_compose(compose: DockerCompose) -> ChannelFinderClient: | ||
| cf_host, cf_port = compose.get_service_host_and_port("cf") |
Contributor
There was a problem hiding this comment.
Magic value - should be moved to variable
tynanford
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.