Skip to content

Bugfix: Change 'units' type from int to str in TCTrackerTimeMetadata#143

Merged
jatkinson1000 merged 2 commits intomainfrom
jatkinson1000-type-fix
Feb 27, 2026
Merged

Bugfix: Change 'units' type from int to str in TCTrackerTimeMetadata#143
jatkinson1000 merged 2 commits intomainfrom
jatkinson1000-type-fix

Conversation

@jatkinson1000
Copy link
Member

Fixes #142

@jatkinson1000
Copy link
Member Author

jatkinson1000 commented Jan 21, 2026

Have cf-python dropped support for Python 3.10?
There was a new release yesterday, but I can't see it explicitly stated.

@sjavis
Copy link
Collaborator

sjavis commented Jan 23, 2026

No, it doesn't seem to have been, and python 3.10 is not yet end of life. So it seems to be a bug in the new release.

I would suggest restricting to cf-python<3.19 for now.

Copy link
Collaborator

@sjavis sjavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missed by the type checker because of a lack of type annotations in cftime. I would suggest adding a return type of TCTrackerTimeMetadata to example_time_metadata to at least ensure there is some type checking going on.

@jatkinson1000
Copy link
Member Author

This is missed by the type checker because of a lack of type annotations in cftime. I would suggest adding a return type of TCTrackerTimeMetadata to example_time_metadata to at least ensure there is some type checking going on.

Done in 1480093

@jatkinson1000
Copy link
Member Author

Rebased to pick up version and linting fixes from main.

@jatkinson1000 jatkinson1000 merged commit 5e99e91 into main Feb 27, 2026
7 checks passed
@jatkinson1000 jatkinson1000 deleted the jatkinson1000-type-fix branch February 27, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small documentation bug re calendar type in TCTrackerMetadata

2 participants