Conversation
![adam-callstackai-action-localhost[bot]](https://avatars.githubusercontent.com/in/954510?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨
Description by Cal
PR Description
This PR introduces a new feature for parsing Webfinger responses, including enhancements to the handling of self links and the addition of type checks for the links.
Diagrams of code changes
sequenceDiagram participant User participant Webfinger participant ActivityPubService participant AccountService User->>Webfinger: Request Webfinger info Webfinger-->>User: Return Webfinger response with self link User->>ActivityPubService: Call to fetch remote account ActivityPubService->>AccountService: Validate account using self link AccountService-->>ActivityPubService: Return account details ActivityPubService-->>User: Return account informationKey Issues
None
Files Changed
File: /.callstack.yaml
Configuration file for the review process.File: /.github/workflows/reviewer.yml
GitHub Actions workflow for PR review.File: /app/lib/webfinger.rb
Improvements to the Webfinger response handling, including self link parsing.File: /app/services/activitypub/fetch_remote_actor_service.rb
Updated to use the new self link method for validation.File: /app/services/resolve_account_service.rb
Refactored to utilize the new self link method.File: /spec/fixtures/requests/activitypub-webfinger.txt
Updated test fixture for activitypub Webfinger response.File: /spec/fixtures/requests/webfinger.txt
Updated test fixture for Webfinger response.File: /spec/lib/webfinger_spec.rb
Added tests for the new self link functionality.File: /spec/services/activitypub/fetch_remote_account_service_spec.rb
Updated tests to reflect changes in self link handling.File: /spec/services/activitypub/fetch_remote_actor_service_spec.rb
Updated tests to reflect changes in self link handling.File: /spec/services/activitypub/process_account_service_spec.rb
Updated tests to reflect changes in self link handling.File: /spec/services/activitypub/fetch_remote_key_service_spec.rb
Updated tests to reflect changes in self link handling.