Frame group perf

[hackal]

✨

Description by Cal

PR Description

This PR introduces performance improvements and refactoring in the handling of frames and groups within the application. It optimizes the rendering process by reducing redundant operations and improving the logic for determining element containment within frames.

Diagrams of code changes

sequenceDiagram
    participant User as User
    participant GitHub as GitHub Actions
    participant CallstackAI as Callstack.ai Action
    participant App as App Component
    participant Frame as Frame Module
    participant Groups as Groups Module
    participant Renderer as Renderer Module

    User->>GitHub: Trigger Callstack.ai PR Review
    GitHub->>CallstackAI: Dispatch workflow with inputs (config, head, base)
    CallstackAI->>GitHub: Review PR using inputs

    App->>Frame: Check if element is in frame
    Frame->>App: Return elements in frame

    App->>Groups: Process group IDs
    Groups->>App: Return processed group IDs

    Renderer->>Frame: Get elements intersecting frame
    Frame->>Renderer: Return intersecting elements

    Renderer->>Renderer: Render visible elements
    Renderer->>Renderer: Render embeddable elements on top
    Renderer->>Renderer: Clip elements not completely in frame
    Renderer->>Renderer: Render selection borders

    Renderer->>User: Display updated scene

Loading

Key Issues

None

Files Changed

File: /.github/workflows/callstack-reviewer.yml

Added a new GitHub Actions workflow for Callstack.ai PR Review with inputs for configuration, head commit SHA, and optional base commit SHA.

File: /src/components/App.tsx

Introduced a `processedGroupIds` map to optimize the selection of elements within frames, reducing redundant checks.

File: /src/frame.ts

Refactored functions to improve performance by optimizing the logic for checking element containment and intersection with frames. Removed redundant functions and improved the `isElementInFrame` function with additional options for processing group IDs.

File: /src/groups.ts

Added a `processedGroupIds` set to avoid redundant processing of group IDs during element selection.

File: /src/renderer/renderScene.ts

Refactored the rendering logic to improve performance by optimizing the order of rendering elements and reducing unnecessary clipping operations. Introduced a `processedGroupIds` map to track processed groups.

[callstackai-action]

No issues found.