Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
개요동아리 박람회 이벤트 관련 모든 컴포넌트, 훅, 유틸리티, 상수, 페이지 및 네비게이션 항목 제거로 인한 기능 완전 삭제(약 1,600줄 삭제). 변경 사항
예상 코드 리뷰 소요 시간🎯 4 (복잡) | ⏱️ ~45분 관련 PR
제안 레이블
제안 리뷰어
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/layout/index.tsx (1)
19-19:⚠️ Potential issue | 🟡 Minor로그인 페이지 판별을 세그먼트 기준으로 좁혀주세요.
Line 19의
includes('/login')는/club/login-guide같은 비로그인 경로도 매치해서 푸터를 숨길 수 있습니다. 공통 레이아웃인 만큼 실제 로그인 라우트만 잡도록 경계 기준으로 판별하는 편이 안전합니다.제안 코드
- const isLoginPage = pathname?.includes('/login'); + const isLoginPage = /(^|\/)login(\/|$)/.test(pathname);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/layout/index.tsx` at line 19, The current isLoginPage uses pathname?.includes('/login'), which incorrectly matches paths like /club/login-guide; change the check to match the login segment boundary only (e.g., test the path segments or use a regex that asserts /login is a full segment such as ^/login(/|$)) so isLoginPage only becomes true for actual login routes—update the isLoginPage definition to use pathname (or pathname?.split('/')) with a segment-based comparison or a boundary-regex instead of includes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@src/components/layout/index.tsx`:
- Line 19: The current isLoginPage uses pathname?.includes('/login'), which
incorrectly matches paths like /club/login-guide; change the check to match the
login segment boundary only (e.g., test the path segments or use a regex that
asserts /login is a full segment such as ^/login(/|$)) so isLoginPage only
becomes true for actual login routes—update the isLoginPage definition to use
pathname (or pathname?.split('/')) with a segment-based comparison or a
boundary-regex instead of includes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7f459a15-46b2-4798-963a-3b5ed8fc9a54
📒 Files selected for processing (94)
public/pair_game/background_heart.webppublic/pair_game/bell-sprite.webppublic/pair_game/bridge.webppublic/pair_game/broken_heart.webppublic/pair_game/card.webppublic/pair_game/check_maru_mari.webppublic/pair_game/cheer_maru_mari.webppublic/pair_game/clubs/1.webppublic/pair_game/clubs/10.webppublic/pair_game/clubs/11.webppublic/pair_game/clubs/12.webppublic/pair_game/clubs/13.webppublic/pair_game/clubs/14.webppublic/pair_game/clubs/15.webppublic/pair_game/clubs/16.webppublic/pair_game/clubs/17.webppublic/pair_game/clubs/18.webppublic/pair_game/clubs/19.webppublic/pair_game/clubs/2.webppublic/pair_game/clubs/20.webppublic/pair_game/clubs/21.webppublic/pair_game/clubs/22.webppublic/pair_game/clubs/23.webppublic/pair_game/clubs/24.webppublic/pair_game/clubs/25.webppublic/pair_game/clubs/26.webppublic/pair_game/clubs/27.webppublic/pair_game/clubs/28.webppublic/pair_game/clubs/29.webppublic/pair_game/clubs/3.webppublic/pair_game/clubs/30.webppublic/pair_game/clubs/31.webppublic/pair_game/clubs/32.webppublic/pair_game/clubs/33.webppublic/pair_game/clubs/34.webppublic/pair_game/clubs/35.webppublic/pair_game/clubs/36.webppublic/pair_game/clubs/37.webppublic/pair_game/clubs/38.webppublic/pair_game/clubs/4.webppublic/pair_game/clubs/5.webppublic/pair_game/clubs/6.webppublic/pair_game/clubs/7.webppublic/pair_game/clubs/8.webppublic/pair_game/clubs/9.webppublic/pair_game/empty_heart.webppublic/pair_game/filled_heart.webppublic/pair_game/heart_mari.webppublic/pair_game/maru_mari.webppublic/pair_game/naver_pay.webppublic/pair_game/qr_code.webppublic/pair_game/ride_maru.webpsrc/app/pair_game/_components/steps/CompletedStep.tsxsrc/app/pair_game/_components/steps/IntroStep.tsxsrc/app/pair_game/_components/steps/IntroStepDesktop.tsxsrc/app/pair_game/_components/steps/IntroStepMobile.tsxsrc/app/pair_game/_components/steps/PlayingStep.tsxsrc/app/pair_game/_components/steps/SubmitStep.tsxsrc/app/pair_game/_components/ui/BellAnimation.tsxsrc/app/pair_game/_components/ui/BridgeMaruMari.tsxsrc/app/pair_game/_components/ui/EventCard.tsxsrc/app/pair_game/_components/ui/GameSkeleton.tsxsrc/app/pair_game/_components/ui/GameStartModal.tsxsrc/app/pair_game/_components/ui/RoundResultModal.tsxsrc/app/pair_game/_constants/RoundResultModalContent.tssrc/app/pair_game/_constants/categoryStyles.tssrc/app/pair_game/_constants/clubs.tssrc/app/pair_game/_constants/gameImages.tssrc/app/pair_game/_constants/heart.tssrc/app/pair_game/_constants/roundConfigs.tssrc/app/pair_game/_contexts/GameFunnelContext.tsxsrc/app/pair_game/_contexts/PairGamePlayingContext.tsxsrc/app/pair_game/_hooks/useCardState.tssrc/app/pair_game/_hooks/useDelayedAction.tssrc/app/pair_game/_hooks/useGameLayoutBg.tssrc/app/pair_game/_hooks/useGameProgress.tssrc/app/pair_game/_hooks/usePairGameForm.tssrc/app/pair_game/_hooks/usePairGameSubmitAction.tssrc/app/pair_game/_hooks/useRoundPhase.tssrc/app/pair_game/_utils/cardStyles.tssrc/app/pair_game/_utils/cardUtils.tssrc/app/pair_game/_utils/clubImages.tssrc/app/pair_game/_utils/clubs.tssrc/app/pair_game/_utils/preloadGameAssets.tssrc/app/pair_game/_utils/roundResultModal.tssrc/app/pair_game/_utils/shareLink.tssrc/app/pair_game/_utils/timerDisplay.tssrc/app/pair_game/_utils/validatePairGameSubmitData.tssrc/app/pair_game/guide/page.tsxsrc/app/pair_game/page.tsxsrc/app/pair_game/prize/page.tsxsrc/components/layout/GameLayout.tsxsrc/components/layout/index.tsxsrc/constants/navItems.ts
💤 Files with no reviewable changes (41)
- src/app/pair_game/_hooks/useGameLayoutBg.ts
- src/app/pair_game/_components/steps/IntroStepDesktop.tsx
- src/app/pair_game/_constants/gameImages.ts
- src/app/pair_game/_hooks/usePairGameForm.ts
- src/app/pair_game/_utils/validatePairGameSubmitData.ts
- src/constants/navItems.ts
- src/app/pair_game/_hooks/useCardState.ts
- src/app/pair_game/_constants/heart.ts
- src/app/pair_game/_components/steps/PlayingStep.tsx
- src/app/pair_game/_constants/categoryStyles.ts
- src/app/pair_game/_hooks/useDelayedAction.ts
- src/app/pair_game/_components/steps/CompletedStep.tsx
- src/app/pair_game/_components/ui/BellAnimation.tsx
- src/app/pair_game/_utils/cardStyles.ts
- src/app/pair_game/guide/page.tsx
- src/app/pair_game/page.tsx
- src/app/pair_game/_hooks/useGameProgress.ts
- src/app/pair_game/_constants/clubs.ts
- src/app/pair_game/_contexts/GameFunnelContext.tsx
- src/app/pair_game/_components/steps/SubmitStep.tsx
- src/app/pair_game/_components/ui/GameStartModal.tsx
- src/app/pair_game/_utils/clubs.ts
- src/app/pair_game/prize/page.tsx
- src/app/pair_game/_components/steps/IntroStepMobile.tsx
- src/app/pair_game/_components/ui/GameSkeleton.tsx
- src/app/pair_game/_constants/RoundResultModalContent.ts
- src/app/pair_game/_constants/roundConfigs.ts
- src/app/pair_game/_utils/timerDisplay.ts
- src/app/pair_game/_components/ui/EventCard.tsx
- src/app/pair_game/_hooks/useRoundPhase.ts
- src/app/pair_game/_utils/cardUtils.ts
- src/app/pair_game/_utils/preloadGameAssets.ts
- src/app/pair_game/_contexts/PairGamePlayingContext.tsx
- src/components/layout/GameLayout.tsx
- src/app/pair_game/_components/steps/IntroStep.tsx
- src/app/pair_game/_components/ui/RoundResultModal.tsx
- src/app/pair_game/_hooks/usePairGameSubmitAction.ts
- src/app/pair_game/_utils/roundResultModal.ts
- src/app/pair_game/_utils/shareLink.ts
- src/app/pair_game/_utils/clubImages.ts
- src/app/pair_game/_components/ui/BridgeMaruMari.tsx
keemsebin
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
🤔 고민했던 내용
💬 리뷰 중점사항
Summary by CodeRabbit
릴리스 노트