Conversation
|
some comments:
|
|
Thanks! Could you streamline/squash your commits to avoid commits like |
|
Re. the python -c "open('README.md', 'w').write(open('../README.md', 'r').read().split('### 11')[0])"I forgot to commit the truncated readme file in the current repository. |
9b0224b to
c83362e
Compare
Makes sense. It looks like I managed to fix it.
Ah I see, okay, then I just renamed it back to what it was before. |
|
Did you commit the |
|
Yes i think that was by accident |
|
Sorry, I'd like to not have the |
| Used for normalization and methods that are common to all MOArchive classes. | ||
| """ | ||
| if hypervolume_final_float_type is None: | ||
| self.hypervolume_final_float_type = MOArchiveBase.hypervolume_final_float_type |
There was a problem hiding this comment.
Do we really want to overwrite self.hypervolume_final_float_type with a default when it was already set? This could happen depending on where and when super is called.
Makes sense yeah. Btw, wouldn't squashing commits when accepting PR fix this? Also I would like to encourage you to fix the code yourself (or maybe @ttusar has someone to do it?). I am not really working in this field anymore and am a bit busy with other stuff in my life at the moment. |
Sure. The minimal change would be to move the folder-remove-commit right behind the commit where the folder was added and then squash/fixup the mistaken commit with the moved commit. Moving commits and fixup can be done with interactive rebase. |
Thanks for letting us know. FYI, we also found some bugs in the current code as described in the new issues. |
Added the MOArchiveBase class with normalization implemented as discussed in issue #16.