fix: ignore comment lines at end of file in CSV parser#396
Open
DCjanus wants to merge 6 commits intoBurntSushi:masterfrom
Open
fix: ignore comment lines at end of file in CSV parser#396DCjanus wants to merge 6 commits intoBurntSushi:masterfrom
DCjanus wants to merge 6 commits intoBurntSushi:masterfrom
Conversation
This test reproduces issue BurntSushi#363, ensuring that comments at the end of the input data are properly ignored by the CSV reader.
Refines the test for ignoring comments at the end of the input data by removing the second record assertion, ensuring that only relevant records are processed. This addresses the behavior outlined in issue BurntSushi#363.
Refines the logic to ensure comments at the end of the file are ignored, addressing issue BurntSushi#363. Additionally, updates the test to validate this behavior.
Introduces a new test case to validate that comments at the end of the file are properly ignored, enhancing the coverage of the existing comment handling logic.
DCjanus
changed the title
DCjanus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue in the CSV parser where comment lines at the end of a file were not properly ignored.
According to expected behavior, if the last line(s) of a CSV file are comments (e.g., start with #), they should not be treated as data records, even if they appear at the end of the file without a trailing newline.
Fix: #363
This is my first contribution to this project. If there are any issues with my implementation, code style, or the contribution process, please let me know. I am happy to make any necessary changes and appreciate your guidance. Thank you for your time and consideration!