refactor(abstract-utxo): replace redundant address test #8104
+141
−1,719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove address generation, validation, format, and cross-coin compatibility tests that are already covered in wasm-utxo: - fixedScript/address.ts: recreates addresses from wallet keys for all chain codes and networks, tests unsupported chain code errors (p2shP2wsh, p2wsh, p2tr, p2trMusig2 on legacy-only chains) - address/utxolibCompat.ts: script-to-address round-trips for all networks with fixture files covering p2sh, p2shP2wsh, p2wsh, p2tr, p2trMusig2, plus cashaddr variants for BCH/ecash - Rust tests in address/networks.rs: segwit, taproot, and legacy script support assertions per network - Rust tests in address/cashaddr.rs: cashaddr encoding, legacy-to-cashaddr translation, prefix and case handling Replace with focused tests for assertFixedScriptWalletAddress, which is the function abstract-utxo actually uses to validate addresses returned from the backend. Delete the 20 addresses-by-chain.json fixture files that were only used by the removed tests. Co-authored-by: Cursor <cursoragent@cursor.com> TICKET: BTC-2650
davidkaplanbitgo
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove address generation, validation, format, and cross-coin compatibility
tests that are already covered in wasm-utxo:
codes and networks, tests unsupported chain code errors (p2shP2wsh, p2wsh,
p2tr, p2trMusig2 on legacy-only chains)
with fixture files covering p2sh, p2shP2wsh, p2wsh, p2tr, p2trMusig2,
plus cashaddr variants for BCH/ecash
support assertions per network
translation, prefix and case handling
Replace with focused tests for assertFixedScriptWalletAddress, which is the
function abstract-utxo actually uses to validate addresses returned from the
backend. Delete the 20 addresses-by-chain.json fixture files that were only
used by the removed tests.
BTC-2650