feat(sdk-coin-iota): add recovery and consolidation support #8089
+739
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-damkondwar
force-pushed
the
WIN-8627
branch
3 times, most recently
from
5af8ff9 to
365b391
Compare
shubham-damkondwar
force-pushed
the
WIN-8627
branch
from
365b391 to
247b11c
Compare
shubham-damkondwar
force-pushed
the
WIN-8627
branch
from
247b11c to
fc93910
Compare
dpkjnr
reviewed
Feb 12, 2026
| * of the addresses being swept | ||
| */ | ||
| async recover(params: IotaRecoveryOptions): Promise<MPCTxs | MPCSweepTxs> { | ||
| if (!params.bitgoKey) { |
Contributor
There was a problem hiding this comment.
why do we need bitgoKey? is it the public key for wallet? if yes then can we rename the param to avoid confusion?
dpkjnr
reviewed
Feb 12, 2026
|
|
||
| const response = await this.makeRpcCall(url, 'iotax_getOwnedObjects', [address, query, cursor, 50]); | ||
| const { data, nextCursor, hasNextPage: more } = response; | ||
| if (nextCursor === cursor) { |
Contributor
There was a problem hiding this comment.
what happens when there is only one page? what will nextCursor have in that case, if it will be null then we might not process the data
dpkjnr
reviewed
Feb 12, 2026
| }; | ||
| } | ||
|
|
||
| private async signRecoveryTransaction( |
Contributor
There was a problem hiding this comment.
most of this function is duplicate of other coin classes, lets move it to some common util
Contributor
|
please add the tests also |
alextse-bg
approved these changes
Feb 12, 2026
Contributor
alextse-bg
left a comment
alextse-bg
left a comment
There was a problem hiding this comment.
wallets-owned changes lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the main changes: adding recover, recoverConsolidations, and sweep methods to the IOTA coin module, along with related constants, utility functions, and environment configuration.
TICKET: WIN-8627