Skip to content

Comments

refactor: De-complexify 'count' metric#97

Merged
smudge merged 1 commit intomainfrom
smudge/stack/8
Feb 12, 2026
Merged

refactor: De-complexify 'count' metric#97
smudge merged 1 commit intomainfrom
smudge/stack/8

Conversation

@smudge
Copy link
Member

@smudge smudge commented Feb 10, 2026 •
edited
Loading

Stacked PRs:

refactor: De-complexify 'count' metric

Given that live_count_grouped is already necessary for computing all
the other live queue metrics, we can reduce the work on MySQL by running
failed_count_grouped (and filtering the scan down to fewer rows)
instead of an entire count against the table.

/no-platform

@smudge
refactor: De-complexify 'count' metric
5a1bd6b 
Given that `live_count_grouped` is already necessary for computing all
the other live queue metrics, we can reduce the work on MySQL by running
`failed_count_grouped` (and filtering the scan down to fewer rows)
instead of an entire count against the table.

stack-info: PR: #97, branch: smudge/stack/8
smudge added a commit that referenced this pull request Feb 10, 2026
@smudge
refactor: De-complexify 'count' metric
e7d2cde 
Given that `live_count_grouped` is already necessary for computing all
the other live queue metrics, we can reduce the work on MySQL by running
`failed_count_grouped` (and filtering the scan down to fewer rows)
instead of an entire count against the table.

stack-info: PR: #97, branch: smudge/stack/8
This was referenced Feb 10, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@smudge smudge marked this pull request as draft February 10, 2026 17:27
@smudge smudge changed the base branch from smudge/stack/7 to main February 10, 2026 17:27
smudge added a commit that referenced this pull request Feb 10, 2026
@smudge
refactor: De-complexify 'count' metric
6fbbb07 
Given that `live_count_grouped` is already necessary for computing all
the other live queue metrics, we can reduce the work on MySQL by running
`failed_count_grouped` (and filtering the scan down to fewer rows)
instead of an entire count against the table.

stack-info: PR: #97, branch: smudge/stack/8
@smudge smudge changed the base branch from main to smudge/stack/7 February 10, 2026 17:27
@smudge smudge marked this pull request as ready for review February 10, 2026 17:27
@smudge smudge marked this pull request as draft February 10, 2026 17:28
@smudge smudge changed the base branch from smudge/stack/7 to main February 10, 2026 17:28
@smudge smudge changed the base branch from main to smudge/stack/7 February 10, 2026 17:29
@smudge smudge mentioned this pull request Feb 10, 2026
Merged
@smudge smudge marked this pull request as ready for review February 10, 2026 17:29
@smudge smudge marked this pull request as draft February 10, 2026 17:31
@smudge smudge changed the base branch from smudge/stack/7 to main February 10, 2026 17:31
@smudge smudge changed the base branch from main to smudge/stack/7 February 10, 2026 17:32
@smudge smudge marked this pull request as ready for review February 10, 2026 17:32
@smudge smudge requested a review from effron February 10, 2026 17:37
@smudge smudge marked this pull request as draft February 10, 2026 18:10
@smudge smudge changed the base branch from smudge/stack/7 to main February 10, 2026 18:10
@smudge smudge changed the base branch from main to smudge/stack/7 February 10, 2026 18:11
@smudge smudge marked this pull request as ready for review February 10, 2026 18:11
smudge added a commit that referenced this pull request Feb 10, 2026
@smudge
refactor: De-complexify 'count' metric
aa7ebef 
Given that `live_count_grouped` is already necessary for computing all
the other live queue metrics, we can reduce the work on MySQL by running
`failed_count_grouped` (and filtering the scan down to fewer rows)
instead of an entire count against the table.

stack-info: PR: #97, branch: smudge/stack/8
smudge added a commit that referenced this pull request Feb 10, 2026
@smudge
refactor: De-complexify 'count' metric
7f7ebd6 
Given that `live_count_grouped` is already necessary for computing all
the other live queue metrics, we can reduce the work on MySQL by running
`failed_count_grouped` (and filtering the scan down to fewer rows)
instead of an entire count against the table.

stack-info: PR: #97, branch: smudge/stack/8
smudge added a commit that referenced this pull request Feb 11, 2026
@smudge
refactor: De-complexify 'count' metric
44b050b 
Given that `live_count_grouped` is already necessary for computing all
the other live queue metrics, we can reduce the work on MySQL by running
`failed_count_grouped` (and filtering the scan down to fewer rows)
instead of an entire count against the table.

stack-info: PR: #97, branch: smudge/stack/8
smudge added a commit that referenced this pull request Feb 11, 2026
@smudge
refactor: De-complexify 'count' metric
34bdbc3 
Given that `live_count_grouped` is already necessary for computing all
the other live queue metrics, we can reduce the work on MySQL by running
`failed_count_grouped` (and filtering the scan down to fewer rows)
instead of an entire count against the table.

stack-info: PR: #97, branch: smudge/stack/8
@smudge smudge marked this pull request as draft February 12, 2026 20:14
@smudge smudge changed the base branch from smudge/stack/7 to main February 12, 2026 20:14
@smudge smudge changed the base branch from main to smudge/stack/7 February 12, 2026 20:15
@smudge smudge marked this pull request as ready for review February 12, 2026 20:15
smudge added a commit that referenced this pull request Feb 12, 2026
@smudge
refactor: De-complexify 'count' metric
6e9ff08 
Given that `live_count_grouped` is already necessary for computing all
the other live queue metrics, we can reduce the work on MySQL by running
`failed_count_grouped` (and filtering the scan down to fewer rows)
instead of an entire count against the table.

stack-info: PR: #97, branch: smudge/stack/8
Base automatically changed from smudge/stack/7 to main February 12, 2026 20:46
effron
effron approved these changes Feb 12, 2026
View reviewed changes
Copy link
Contributor

@effron effron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainLGTM

@smudge smudge merged commit af898a0 into main Feb 12, 2026
47 checks passed
@smudge smudge deleted the smudge/stack/8 branch February 12, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@effron effron effron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smudge @effron