Skip to content

Comments

style: Add (passing) tests for regression coverage#102

Merged
smudge merged 1 commit intoBetterment:mainfrom
smudge:perform_later-testing
Feb 20, 2026
Merged

style: Add (passing) tests for regression coverage#102
smudge merged 1 commit intoBetterment:mainfrom
smudge:perform_later-testing

Conversation

@smudge
Copy link
Member

@smudge smudge commented Feb 20, 2026

@medlefsen noticed that ActiveJob states this in their docs w.r.t. perform_later:

Returns an instance of the job class queued with arguments available in Job#arguments or false if the enqueue did not succeed.

Since silently returning false would appear to conflict with our preference for guaranteeing message delivery, I'm adding a couple regression test cases to make more explicit the current behavior, which presumably is specific to the AJ backend.

The delayed backend will not return false from perform_later, and will instead bubble out an exception.

/no-platform

@smudge smudge requested a review from medlefsen February 20, 2026 20:32
Copy link
Member

@samandmoore samandmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainlgtm platformlgtm

@smudge smudge merged commit 00d575c into Betterment:main Feb 20, 2026
25 checks passed
@smudge smudge deleted the perform_later-testing branch February 20, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants