fix: use find instead of first when locating YAML keys with line numbers#14
Open
btrautmann wants to merge 3 commits intoBetterment:mainfrom
Open
fix: use find instead of first when locating YAML keys with line numbers#14btrautmann wants to merge 3 commits intoBetterment:mainfrom
btrautmann wants to merge 3 commits intoBetterment:mainfrom
Conversation
btrautmann
force-pushed
the
bt/fix/fix-yaml-violation-line
branch
from
066c1a0 to
55ea63b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect line number reporting for lint violations when YAML keys with hyphens (e.g., runs-on) are normalized to underscores (runs_on)
The bug caused violations to be reported on the first key in a hash instead of the actual offending key
Test plan
Added spec to verify line numbers are preserved when normalizing hyphenated keys that are not first in the hash
All 59 tests pass