custom health check to verify mail password is set #9
Conversation
added test for new mail password healthcheck removed stubbing for gpg key
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
r+, this addresses the ticket's ask.
I still think it would be useful to eventually grow a check that tries to connect to SMTP. It doesn't need to send a message (as we don't want to waste email traffic), but it could AUTH, wait for a 2.7.0, then NOOP to ensure the connection works. That can be later.
danschmidt5189
left a comment
danschmidt5189
left a comment
There was a problem hiding this comment.
The ticket asks to test that the credentials are valid ("Credential invalidity (e.g. on expiration) is an important case for this check, so it should be covered.") so this actually doesn't meet the requirement.
You can get the app's SMTP configuration via ActionMailer::Base.smtp_settings, then use that to configure a test connection via the underlying Net::SMTP library. (I don't think you can get that object from ActionMailer, so you do have to create it yourself; I'd check the ActionMailer internals to make sure your method matches what it does internally.)
|
I changed it so it's making a real smtp call. I think custom_mailer that was added makes the action_mailer in okcomputer call unnecessary since it's only doing a ping. Should I take that out? |
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Question on logging exceptions, otherwise looks great.
spec/request/okcomputer_spec.rb
Outdated
| get '/health' | ||
| expect(response.parsed_body.keys).to match_array %w[ | ||
| action-mailer | ||
| custom-mailer |
There was a problem hiding this comment.
One or the other of these will need to be removed once you consolidate the mailer checks.
Adds healtcheck to verify Mail password is set