-
Notifications
You must be signed in to change notification settings - Fork 15
Delete button redesign #1669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete button redesign #1669
Conversation
|
Great job I don't see any problem! |
MImran2002
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously Reviewed (Adding this to be able to complete the merge). Note: Since, I was the last pusher either you or Imran have to merge these changes. I fixed the Resource Reader Issue causing the tests to fail.
|
I would ask to move the red bins closer to the background check that was saved, just like it was before the X |
Karina-Agliullova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is looking good and clean


Issue Description
Fixes #1591
On the student's "my profile page", the deletion button within the "Background Check" accordion is not very user-friendly. During the usability study, the majority of participants did not know how to delete the Background check with the red X. This x will be seen after you select a status, pick a date, and press save. Redesign the deletion button.
Changes
Before
After
Testing