Skip to content

Conversation

@bakobagassas
Copy link
Contributor

@bakobagassas bakobagassas commented Jan 26, 2026

Issue Description

Fixes #1591

On the student's "my profile page", the deletion button within the "Background Check" accordion is not very user-friendly. During the usability study, the majority of participants did not know how to delete the Background check with the red X. This x will be seen after you select a status, pick a date, and press save. Redesign the deletion button.

Changes

  • Now the delete buttons are red bins instead of a simple X.

Before

image

After

image

Testing

  • Log in as an admin
  • Go to any profile
  • Go to background check, add a couple of background checks, you should be able to see the bin delete button.

@bakobagassas bakobagassas self-assigned this Jan 28, 2026
@MImran2002
Copy link
Contributor

Great job I don't see any problem!

MImran2002
MImran2002 previously approved these changes Feb 9, 2026
Copy link
Contributor

@MImran2002 MImran2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@Meatchema
Copy link
Contributor

The Bin are showing properly and they work:
Created Background Info-
image
After Deleting-
image

@Meatchema Meatchema self-requested a review February 10, 2026 20:15
Meatchema
Meatchema previously approved these changes Feb 10, 2026
Copy link
Contributor

@Meatchema Meatchema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously Reviewed (Adding this to be able to complete the merge). Note: Since, I was the last pusher either you or Imran have to merge these changes. I fixed the Resource Reader Issue causing the tests to fail.

@Karina-Agliullova
Copy link
Contributor

I would ask to move the red bins closer to the background check that was saved, just like it was before the X

@github-actions
Copy link

View Code Coverage

Copy link
Contributor

@Karina-Agliullova Karina-Agliullova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is looking good and clean

@Karina-Agliullova Karina-Agliullova merged commit 39d8c2e into development Feb 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesign a delete button on Background check

4 participants