[Automation] Generate SDK based on TypeSpec 0.41.0#48314
Open
azure-sdk wants to merge 4 commits intoAzure:mainfrom
Open
[Automation] Generate SDK based on TypeSpec 0.41.0#48314azure-sdk wants to merge 4 commits intoAzure:mainfrom
azure-sdk wants to merge 4 commits intoAzure:mainfrom
Conversation
Contributor
|
FromSource run failure is not related to this PR. |
XiaofeiCao
requested review from
a team,
ArthurMa1978,
XiaofeiCao,
benbp,
chahibi,
haolingdong-msft,
karthick-rn,
mandarinamdar,
raych1,
weidongxu-microsoft and
weshaggard
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TypeSpec Java emitter from 0.40.0 to 0.41.0 and autorest.java from 4.1.62 to 4.1.63, along with cherry-picked engineering system changes from PR #48226 that keep premium management samples in their generated location instead of copying them to the azure-resourcemanager aggregator module.
Changes:
- Bumps
@azure-tools/typespec-javato 0.41.0 and@autorest/javato 4.1.63, along with transitive dependency updates (@typespec/http,@azure-tools/typespec-client-generator-core, etc.) - Removes the logic that copied generated premium samples to
azure-resourcemanagerand updatedversion_client.txt/pom.xmlwith unreleased entries (from both gulpfile.js Swagger path and generate.py TypeSpec path) - Regenerates SDK samples for keyvault and containerregistry packages using the new emitter version
Reviewed changes
Copilot reviewed 5 out of 114 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/emitter-package.json | Bumps typespec-java to 0.41.0 and related dev dependencies |
| eng/emitter-package-lock.json | Updated lockfile reflecting new dependency versions |
| eng/automation/parameters.py | Bumps autorest.java to 4.1.63 |
| eng/automation/generate.py | Removes premium sample moving/version updating logic and unused imports |
| sdk/resourcemanager/gulpfile.js | Removes premium sample copy, unreleased version entry, and aggregator pom update logic |
| sdk/recoveryservicesbackup/.../apiview_properties.json | Deleted (regeneration artifact) |
| sdk/keyvault/.../generated/*.java | New generated sample files from TypeSpec 0.41.0 |
| sdk/containerregistry/.../generated/*.java | New generated sample files from TypeSpec 0.41.0 |
Files not reviewed (1)
- eng/emitter-package-lock.json: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next step be, delete samples under azure-resourcemanager. Guess it's not urgent before we hit breaking changes for premium libraries.
Not sure any changes to example-automation script should be made. Will probably delete special logic to azure-resourcemanager after samples are removed.
[Automation] Generate SDK based on TypeSpec 0.41.0