Decrypt Protected Settings in VMSnapshot Extension for FIPS 140-3 AES256 support and backward compatibility for DES_EDE3_CBC encryption#2122
Open
deveshjagwani wants to merge 2 commits intomasterfrom
Open
Conversation
deveshjagwani
requested review from
arisettisanjana,
mearvind and
vityagi
as code owners
deveshjagwani
changed the title
ppusuluri-ms
reviewed
Nov 3, 2025
ppusuluri-ms
requested changes
Nov 3, 2025
| return cleartxt | ||
| else: | ||
| self.log("CMS decryption failed with return code: " + str(result[0]) + ", attempting fallback to SMIME") | ||
| except Exception as e: |
Contributor
There was a problem hiding this comment.
is there any failure scenario logs like the decryption via the cms fails in that case we are logging the error and falling back to the other approach, but does the error have any details related to key or cert as this data would be pushed to kusto and it should not be having any sensitive info
arisettisanjana
requested changes
Mar 10, 2026
| @@ -205,6 +205,67 @@ def error(self, message): | |||
| def fetch_log_message(self): | |||
| return self.log_message | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Since protected settings are used in guest path, please do test the guest path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FedRamp requirement security task: 34614091