Closed
Conversation
AaronRM
requested changes
Apr 11, 2023
Contributor
|
Is 'master' in a known state? IIRC it was (at some point) out of phase with both LAD release branches. |
Contributor
Author
I'm unsure - should I merge directly into the LAD 4 release branch instead? I can copy the changes and make a new PR off of |
Contributor
Author
|
Re-creating PR to merge into the LAD 4.0 branch, instead of master: #1709 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially LAD would return success on user errors (invalid config, not supported OS, etc) as a legacy ability to not impede VM startup. However, this was causing confusion when LAD would return success in a failure scenario. Changed these scenarios to instead return failure, as LAD was not able to successfully start up.