Conversation
huiii99
requested review from
DanielMicrosoft,
ReaNAiveD,
jsntcy,
kairu-ms,
necusjz and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network private-endpoint create | cmd network private-endpoint create added parameter application_gateway_ip_configurations |
||
| network private-endpoint create | cmd network private-endpoint create added parameter default_outbound_access |
||
| network private-endpoint create | cmd network private-endpoint create added parameter ip_version_type |
||
| network private-endpoint create | cmd network private-endpoint create added parameter ipam_pool_prefix_allocations |
||
| network private-endpoint create | cmd network private-endpoint create added parameter service_gateway |
||
| network private-endpoint create | cmd network private-endpoint create added parameter sharing_scope |
||
| network private-endpoint list | cmd network private-endpoint list added parameter pagination_limit |
||
| network private-endpoint list | cmd network private-endpoint list added parameter pagination_token |
||
| network private-endpoint list-types | cmd network private-endpoint list-types added parameter pagination_limit |
||
| network private-endpoint list-types | cmd network private-endpoint list-types added parameter pagination_token |
||
| network private-endpoint update | cmd network private-endpoint update added parameter ip_version_type |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Azure Private Endpoint CLI support for selecting IP stack (IPv4/IPv6/DualStack), aligning the AAZ implementations with a newer Network RP API version and validating behavior via a new live scenario test.
Changes:
- Add
--ip-version-typetoaz network private-endpoint createandaz network private-endpoint update. - Bump
privateEndpointAAZ commands to Network API version2025-05-01and extend read schemas accordingly. - Add a new live scenario test covering
createfor IPv4/IPv6/DualStack.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py | Adds a live scenario test validating --ip-version-type on private-endpoint create. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/private_endpoint/_create.py | Adds --ip-version-type to create and includes it in the request payload; also introduces additional subnet-related args. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/private_endpoint/_update.py | Adds --ip-version-type to update and maps it into the update payload. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/private_endpoint/_show.py | Updates API version and read schema to surface ipVersionType and other newer fields. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/private_endpoint/_wait.py | Updates API version and read schema to match 2025-05-01. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/private_endpoint/_list.py | Updates API version and enables pagination for list results. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/private_endpoint/_list_types.py | Enables pagination for list-types results. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/private_endpoint/_delete.py | Updates API version for delete. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/private_endpoint/_create.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/private_endpoint/_update.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
Collaborator
|
Please fix CI issues |
feat: update test case fix: update test case recording fix: update recording fix: update recording fix: update recording fix: update recording dev
huiii99
force-pushed
the
network-pe-support-ip-type
branch
from
ef95dd9 to
11cc8cd
Compare
huiii99
changed the title
az network private-endpoint create/update support --ip-version-type
huiii99
changed the title
az network private-endpoint create/update support --ip-version-typeaz network private-endpoint create/update: Add parameter --ip-version-type to support IPv6
necusjz
approved these changes
Mar 11, 2026
calvinhzy
approved these changes
Mar 11, 2026
yanzhudd
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network private-endpoint createaz network private-endpoint updateDescription
This feature adds support for configuring the IP version type of Azure Private Endpoints through Azure CLI, enabling customers to create and update Private Endpoints with IPv4, IPv6, or DualStack connectivity.
aaz: Azure/aaz#958
Testing Guide
azdev test test_network_private_endpoint_ip_version_type --liveHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.