Skip to content

{AKS} az aks enable-addons: Terminate progress bar on role assignment/deletion failure in AKS addon configuration #32928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanzhudd merged 2 commits into from
Mar 10, 2026
+4 −2
Merged

{AKS} az aks enable-addons: Terminate progress bar on role assignment/deletion failure in AKS addon configuration #32928

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a70ba5
fix
FumingZhang Mar 6, 2026
00110e1
fix
FumingZhang Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/azure-cli/azure/cli/command_modules/acs/_roleassignments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,9 @@ def add_role_assignment(cmd, role, service_principal_msi_id, is_service_principa
logger.error(str(ex))
time.sleep(delay + delay * x)
else:
hook.end(message="AAD role propagation failed", value=1.0, total_val=1.0)
return False
hook.add(message="AAD role propagation done", value=1.0, total_val=1.0)
hook.end(message="AAD role propagation done", value=1.0, total_val=1.0)
logger.info("AAD role propagation done")
return True

Expand Down Expand Up @@ -205,8 +206,9 @@ def delete_role_assignments(cli_ctx, role, service_principal, delay=2, scope=Non
logger.error(str(ex))
time.sleep(delay + delay * x)
else:
hook.end(message="AAD role deletion failed", value=1.0, total_val=1.0)
return False
hook.add(message="AAD role deletion done", value=1.0, total_val=1.0)
hook.end(message="AAD role deletion done", value=1.0, total_val=1.0)
logger.info("AAD role deletion done")
return True

Expand Down