Open
Conversation
xuming-ms
requested review from
DanielMicrosoft,
ReaNAiveD,
bebound,
calvinhzy,
jiasli,
jsntcy,
kairu-ms,
necusjz and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Account
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Azure CLI core authentication dependency (MSAL) to incorporate an upstream fix that avoids unnecessary network-dependent authority/cloud discovery in known clouds, addressing az login hangs/failures (e.g., Bleu cloud).
Changes:
- Bump MSAL from
1.35.0b1to1.35.1inazure-cli-coreinstall requirements (platform-selective). - Update pinned MSAL versions in platform-specific
requirements.py3.*.txtfiles (Windows usesmsal[broker], Linux/Darwin usemsal).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/requirements.py3.windows.txt | Pin msal[broker] to 1.35.1 for Windows builds. |
| src/azure-cli/requirements.py3.Linux.txt | Pin msal to 1.35.1 for Linux builds. |
| src/azure-cli/requirements.py3.Darwin.txt | Pin msal to 1.35.1 for macOS builds. |
| src/azure-cli-core/setup.py | Update install_requires to msal[broker]==1.35.1 (win32) / msal==1.35.1 (non-win32). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@xuming-ms please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Azure CLI’s MSAL (Python) dependency to pick up the upstream fix that prevents auth discovery from performing unnecessary network-dependent lookups in known clouds. This resolves az login hangs/failures seen in Bleu cloud