Skip to content

{Misc.} Port credscan false positive fix from release to dev #32881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naga-nandyala wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

{Misc.} Port credscan false positive fix from release to dev #32881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions scripts/ci/credscan/CredScanSuppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,18 @@
"src\\azure-cli\\azure\\cli\\command_modules\\network\\tests\\latest\\test_network_commands.py"
],
"_justification": "[Network] False positive"
},
{
"placeholder": "asdfghjkl",
"_justification": "[ARO] Dummy client_secret value in test_validators.py unit tests"
},
{
"placeholder": "secret_123",
"_justification": "[ARO] Dummy client_secret value in test_validators.py unit tests"
},
{
Comment on lines +687 to +695
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new suppressions are global placeholder matches, which can unintentionally suppress unrelated findings elsewhere in the repo. In particular, asdfghjkl also appears in src/azure-cli/azure/cli/command_modules/resource/tests/latest/test-largesize-parameters.json, so this suppression would hide any CredScan hits there too. Please scope the suppression to the specific ARO test file (or use a more specific placeholder string) so only the intended false positive is suppressed.

Suggested change
{
"placeholder": "asdfghjkl",
"_justification": "[ARO] Dummy client_secret value in test_validators.py unit tests"
},
{
"placeholder": "secret_123",
"_justification": "[ARO] Dummy client_secret value in test_validators.py unit tests"
},
{
{
"file": [
"src/azure-cli/azure/cli/command_modules/aro/tests/latest/test_validators.py"
],
"placeholder": "asdfghjkl",
"_justification": "[ARO] Dummy client_secret value in test_validators.py unit tests"
},
{
"file": [
"src/azure-cli/azure/cli/command_modules/aro/tests/latest/test_validators.py"
],
"placeholder": "secret_123",
"_justification": "[ARO] Dummy client_secret value in test_validators.py unit tests"
},
{
"file": [
"src/azure-cli/azure/cli/command_modules/aro/tests/latest/test_validators.py"
],

Copilot uses AI. Check for mistakes.
"placeholder": "client_id_456",
"_justification": "[ARO] Dummy client_id value in test_validators.py unit tests"
Comment on lines +688 to +697
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For secret_123 and client_id_456, consider scoping the suppression to the specific aro/tests/latest/test_validators.py file (or a more specific placeholder string). Leaving these as global placeholders increases the chance of masking real findings if the same strings appear in other tests or fixtures later.

Suggested change
"placeholder": "asdfghjkl",
"_justification": "[ARO] Dummy client_secret value in test_validators.py unit tests"
},
{
"placeholder": "secret_123",
"_justification": "[ARO] Dummy client_secret value in test_validators.py unit tests"
},
{
"placeholder": "client_id_456",
"_justification": "[ARO] Dummy client_id value in test_validators.py unit tests"
"file": [
"src\\azure-cli\\azure\\cli\\command_modules\\aro\\tests\\latest\\test_validators.py"
],
"_justification": "[ARO] Dummy client_secret value in test_validators.py unit tests (asdfghjkl)"
},
{
"file": [
"src\\azure-cli\\azure\\cli\\command_modules\\aro\\tests\\latest\\test_validators.py"
],
"_justification": "[ARO] Dummy client_secret value in test_validators.py unit tests (secret_123)"
},
{
"file": [
"src\\azure-cli\\azure\\cli\\command_modules\\aro\\tests\\latest\\test_validators.py"
],
"_justification": "[ARO] Dummy client_id value in test_validators.py unit tests (client_id_456)"

Copilot uses AI. Check for mistakes.
}
]
}