Open
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @audunn, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| netappfiles account quota-limit | sub group netappfiles account quota-limit added |
||
| netappfiles volume create | cmd netappfiles volume create added parameter desired_ransomware_protection_state |
||
| netappfiles volume list-quota-report | cmd netappfiles volume list-quota-report added |
||
| netappfiles volume ransomware-report | sub group netappfiles volume ransomware-report added |
||
| netappfiles volume update | cmd netappfiles volume update added parameter ransomware_protection |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jiasli,
kairu-ms and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the az netappfiles command module to use API version 2025-12-01, and introduces new Advanced Ransomware Protection (ARP) and quota-report capabilities.
Changes:
- Bump NetAppFiles AAZ-generated command surfaces to
api-version=2025-12-01. - Add ARP support (desired ransomware protection state, ransomware report commands).
- Add volume quota reporting command and introduce breaking-change guidance for quota-rule migration.
Reviewed changes
Copilot reviewed 148 out of 205 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/test_volume_commands.py | Adds a live scenario test covering ARP enablement and ransomware-report list/show behavior. |
| src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/test_backup_commands.py | Adds a delay before volume update in backup tests to reduce eventual-consistency failures. |
| src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_string_size.yaml | Updates recording for the new api-version and CLI/SDK user-agent changes. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume_group/_wait.py | Bumps api-version and includes ARP schema fields in volume-group wait responses. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume_group/_update.py | Bumps api-version and wires ARP properties into volume-group update request/response schemas. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume_group/_show.py | Bumps api-version and includes ARP schema fields in volume-group show responses. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume_group/_list.py | Bumps api-version for volume-group list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume_group/_delete.py | Bumps api-version for volume-group delete. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume_group/_create.py | Bumps api-version and adds ARP settings into volume-group create schema/content. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/replication/_suspend.py | Bumps api-version for replication suspend. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/replication/_status.py | Bumps api-version for replication status. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/replication/_resume.py | Bumps api-version for replication resume. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/replication/_remove.py | Bumps api-version for replication remove. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/replication/_reestablish.py | Bumps api-version for replication reestablish. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/replication/_re_initialize.py | Bumps api-version for replication re-initialize. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/replication/_populate_availability_zone.py | Bumps api-version and includes ARP fields in schema. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/replication/_perform_replication_transfer.py | Bumps api-version for perform replication transfer. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/replication/_peer_external_cluster.py | Bumps api-version for peer external cluster. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/replication/_list.py | Bumps api-version and relaxes requiredness of remote_volume_resource_id in list schema. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/replication/_finalize_external_replication.py | Bumps api-version for finalize external replication. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/replication/_authorize_external_replication.py | Bumps api-version for authorize external replication. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/replication/_approve.py | Bumps api-version for approve replication. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/ransomware_report/_show.py | Adds new command to show a ransomware report (ARP). |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/ransomware_report/_list.py | Adds new command to list ransomware reports (ARP). |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/ransomware_report/_clear_suspect.py | Adds new command to clear ransomware-report suspects. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/ransomware_report/init.py | Exports ransomware-report commands for module loading. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/ransomware_report/__cmd_group.py | Adds the ransomware-report command group. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/quota_rule/_wait.py | Bumps api-version for volume quota-rule wait. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/quota_rule/_update.py | Bumps api-version for volume quota-rule update. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/quota_rule/_show.py | Bumps api-version for volume quota-rule show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/quota_rule/_list.py | Bumps api-version for volume quota-rule list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/quota_rule/_delete.py | Bumps api-version for volume quota-rule delete. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/quota_rule/_create.py | Bumps api-version for volume quota-rule create. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/latest_restore_status/current/_show.py | Bumps api-version for latest restore status. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/latest_backup_status/current/_show.py | Bumps api-version for latest backup status. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/export_policy/_wait.py | Bumps api-version and includes ARP fields in volume schema. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/export_policy/_update.py | Bumps api-version and includes ARP fields in volume schema. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/export_policy/_show.py | Bumps api-version and includes ARP fields in volume schema. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/export_policy/_remove.py | Bumps api-version and includes ARP fields in volume schema. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/export_policy/_list.py | Bumps api-version and includes ARP fields in volume schema. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/export_policy/_add.py | Bumps api-version and includes ARP fields in volume schema. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_wait.py | Bumps api-version and includes ARP fields in volume wait schema. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_update.py | Bumps api-version and adds ARP update arguments and payload wiring. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_splitclonefromparent.py | Bumps api-version and includes ARP fields in schema. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_show.py | Bumps api-version and includes ARP fields in schema. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_revert_relocation.py | Bumps api-version for revert relocation. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_revert.py | Bumps api-version for volume revert. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_reset_cifs_pw.py | Bumps api-version for CIFS password reset. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_relocate.py | Bumps api-version for relocate. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_pool_change.py | Bumps api-version for pool change. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_migrate_backup.py | Bumps api-version for volume migrate backup. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_list_quota_report.py | Adds new volume list-quota-report command (preview). |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_list.py | Bumps api-version and includes ARP fields in volume list schema. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_get_groupid_list_for_ldapuser.py | Bumps api-version for get-groupid-list-for-ldapuser. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_finalize_relocation.py | Bumps api-version for finalize relocation. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_delete.py | Bumps api-version for volume delete. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_create.py | Bumps api-version and adds --desired-arp-state/--desired-ransomware-protection-state handling. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_break_file_locks.py | Bumps api-version for break file locks. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/init.py | Exposes the new list-quota-report command entrypoint. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/usage/_show.py | Bumps api-version for usage show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/usage/_list.py | Bumps api-version for usage list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/subvolume/metadata/_show.py | Bumps api-version for subvolume metadata show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/subvolume/_wait.py | Bumps api-version for subvolume wait. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/subvolume/_update.py | Bumps api-version for subvolume update. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/subvolume/_show.py | Bumps api-version for subvolume show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/subvolume/_list.py | Bumps api-version for subvolume list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/subvolume/_delete.py | Bumps api-version for subvolume delete. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/subvolume/_create.py | Bumps api-version for subvolume create. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/policy/_wait.py | Bumps api-version for snapshot policy wait. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/policy/_volumes.py | Bumps api-version and includes ARP fields in listed volumes schema. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/policy/_update.py | Bumps api-version for snapshot policy update. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/policy/_show.py | Bumps api-version for snapshot policy show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/policy/_list.py | Bumps api-version for snapshot policy list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/policy/_delete.py | Bumps api-version for snapshot policy delete. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/policy/_create.py | Bumps api-version for snapshot policy create. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/_wait.py | Bumps api-version for snapshot wait. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/_update.py | Bumps api-version for snapshot update. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/_show.py | Bumps api-version for snapshot show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/_restore_files.py | Bumps api-version for snapshot restore files. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/_list.py | Bumps api-version for snapshot list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/_delete.py | Bumps api-version for snapshot delete. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/snapshot/_create.py | Bumps api-version for snapshot create. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/resource/region_info/default/_show.py | Bumps api-version for region-info default show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/resource/region_info/_list.py | Bumps api-version for region-info list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/resource/_query_region_info.py | Bumps api-version for query-region-info. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/quota_limit/_show.py | Bumps api-version for quota-limit show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/quota_limit/_list.py | Bumps api-version for quota-limit list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/pool/_wait.py | Bumps api-version for pool wait. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/pool/_update.py | Bumps api-version for pool update. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/pool/_show.py | Bumps api-version for pool show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/pool/_list.py | Bumps api-version for pool list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/pool/_delete.py | Bumps api-version for pool delete. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/pool/_create.py | Bumps api-version for pool create. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_vault/backup/_wait.py | Bumps api-version for backup-vault backup wait. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_vault/backup/_update.py | Bumps api-version for backup-vault backup update. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_vault/backup/_show.py | Bumps api-version for backup-vault backup show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_vault/backup/_restore_file.py | Bumps api-version for backup-vault backup restore-file. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_vault/backup/_list.py | Bumps api-version for backup-vault backup list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_vault/backup/_delete.py | Bumps api-version for backup-vault backup delete. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_vault/backup/_create.py | Bumps api-version for backup-vault backup create. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_vault/_wait.py | Bumps api-version for backup-vault wait. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_vault/_update.py | Bumps api-version for backup-vault update. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_vault/_show.py | Bumps api-version for backup-vault show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_vault/_list.py | Bumps api-version for backup-vault list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_vault/_delete.py | Bumps api-version for backup-vault delete. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_vault/_create.py | Bumps api-version for backup-vault create. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_policy/_wait.py | Bumps api-version for backup-policy wait. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_policy/_update.py | Bumps api-version for backup-policy update. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_policy/_show.py | Bumps api-version for backup-policy show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_policy/_list.py | Bumps api-version for backup-policy list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_policy/_delete.py | Bumps api-version for backup-policy delete. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/backup_policy/_create.py | Bumps api-version for backup-policy create. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/ad/_wait.py | Bumps api-version for active-directory wait. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/ad/_update.py | Bumps api-version for active-directory update. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/ad/_show.py | Bumps api-version for active-directory show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/ad/_remove.py | Bumps api-version for active-directory remove. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/ad/_list.py | Bumps api-version for active-directory list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/ad/_add.py | Bumps api-version for active-directory add. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_wait.py | Bumps api-version for account wait. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_update.py | Bumps api-version for account update. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_transitiontocmk.py | Bumps api-version for transition-to-cmk. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_show.py | Bumps api-version for account show. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_renew_credentials.py | Bumps api-version for renew credentials. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_migrate_backup.py | Bumps api-version for account migrate backup. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_list.py | Bumps api-version for account list. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_get_key_vault_status.py | Bumps api-version for get key vault status. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_delete.py | Bumps api-version for account delete. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_create.py | Bumps api-version for account create. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_change_key_vault.py | Bumps api-version for change key vault. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/_update_network_sibling_set.py | Bumps api-version for update network sibling set. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/_query_network_sibling_set.py | Bumps api-version for query network sibling set. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/_check_quota_availability.py | Bumps api-version for check quota availability. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/_check_name_availability.py | Bumps api-version for check name availability. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/_check_file_path_availability.py | Bumps api-version and updates example subscription ID placeholder. |
| src/azure-cli/azure/cli/command_modules/netappfiles/_breaking_change.py | Adds argument deprecations and breaking-change notices for quota-rule migration and network feature defaults. |
Comments suppressed due to low confidence (6)
src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_update.py:1
- PR history notes call out adding a new parameter
--desired-ransomware-protection-stateforaz netappfiles volume update, but the current shape nests it under--ransomware-protection(i.e., users must pass an object to set a single value). Consider exposing--desired-ransomware-protection-statedirectly on the update command (matchingvolume create) and mapping it toproperties.dataProtection.ransomwareProtection.desiredRansomwareProtectionStateunder the hood; you can still keep the object form for extensibility if needed.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_string_size.yaml:1 - This recording switched the ARM endpoint host from
management.azure.comtouksouth.management.azure.comwhile still operating onlocations/eastus. CLI playback matching is typically sensitive to the full request URI; this can cause test playback failures when the test runner targets the global ARM endpoint. Re-record using the standard ARM endpoint for the target cloud (or ensure the test framework/environment is configured consistently so playback uses the same host).
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_string_size.yaml:1 - This recording switched the ARM endpoint host from
management.azure.comtouksouth.management.azure.comwhile still operating onlocations/eastus. CLI playback matching is typically sensitive to the full request URI; this can cause test playback failures when the test runner targets the global ARM endpoint. Re-record using the standard ARM endpoint for the target cloud (or ensure the test framework/environment is configured consistently so playback uses the same host).
src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/ransomware_report/_list.py:1 - The command help/docstring formatting is hard to read and includes an extra trailing quote (
...restore data\"). Consider restructuring into paragraphs with proper spacing/newlines and removing the stray quote soaz netappfiles volume ransomware-report list -houtput is clean. Similar formatting issues appear in the related ransomware-report commands as well.
src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/ransomware_report/_clear_suspect.py:1 - The docstring has run-on sentences (missing spaces after periods) and ends with a trailing comma inside the text. Please add missing spaces/newlines and remove the trailing comma so the generated help text is readable.
src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_list_quota_report.py:1 - This PR introduces the new
az netappfiles volume list-quota-reportcommand, but there’s no corresponding scenario test/recording added in the netappfiles test suite. Please add at least one test that exercises the command (including common filters like--quota-type/--quota-targetand--usage-threshold-percentage) to prevent regressions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/netappfiles/_breaking_change.py
Outdated
Show resolved
Hide resolved
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32828 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32828 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32828 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32828 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32828 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32828 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32828 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az netappfiles
Description
Updates az netappfiles to api-version 2025-12-01
Testing Guide
History Notes
[NetAppFiles]
az netapfiles volume create: Add new paramter--desired-ransomware-protection-stateto enable or disable Advanced Ransomware Reports[NetAppFiles]
az netapfiles volume update: Add new paramter--desired-ransomware-protection-stateto enable or disable Advanced Ransomware Reports[NetAppFiles]
az netapfiles volume ransomware-report show: Add new command to show Advanced Ransomware Reports[NetAppFiles]
az netapfiles volume ransomware-report list: Add new command to list Advanced Ransomware Reports[NetAppFiles]
az netapfiles volume ransomware-report clear-suspect: Add new command to clear suspects in Advanced Ransomware Reports with false-postitive or potential threat[NetAppFiles]
az netapfiles volume list-quota-report: Add new command to list quota reports for volumesThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.