Skip to content

Adding CLI Implementation for App Routing Istio#9669

Open
jaiveerk wants to merge 10 commits intoAzure:mainfrom
jaiveerk:jkatariya/meshless-istio-preview
Open

Adding CLI Implementation for App Routing Istio#9669
jaiveerk wants to merge 10 commits intoAzure:mainfrom
jaiveerk:jkatariya/meshless-istio-preview

Conversation

@jaiveerk
Copy link
Contributor

Adding app routing istio flags/commands.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create
az aks update

az aks approuting

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings March 10, 2026 22:28
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Mar 10, 2026

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd aks approuting gateway sub group aks approuting gateway added
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_app_routing_istio
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_app_routing_istio
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_app_routing_istio

@azure-client-tools-bot-prd
Copy link

Hi @jaiveerk,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 10, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Hi @jaiveerk

Release Suggestions

Module: aks-preview

  • Update VERSION to 19.0.0b26 in src/aks-preview/setup.py

Notes

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds CLI support in aks-preview for configuring “App Routing Istio” (Istio as a Gateway API implementation for App Routing) across az aks create, az aks update, and a new az aks approuting gateway istio command group.

Changes:

  • Add new CLI flags --enable-app-routing-istio/--enable-ari (create/update) and --disable-app-routing-istio/--disable-ari (update).
  • Add new approuting subcommands: az aks approuting gateway istio enable|disable.
  • Wire the new flags into the managed cluster decorator and add unit + scenario test coverage.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Adds context getters and create/update mutators to set App Routing Istio mode under ingress profile.
src/aks-preview/azext_aks_preview/custom.py Adds approuting “gateway istio” enable/disable custom commands and plumbs update flow.
src/aks-preview/azext_aks_preview/commands.py Registers the new aks approuting gateway istio command group.
src/aks-preview/azext_aks_preview/_params.py Adds new CLI parameters and aliases for create/update.
src/aks-preview/azext_aks_preview/_help.py Documents new flags and the new approuting command group.
src/aks-preview/azext_aks_preview/_consts.py Adds string constants for the new Istio mode values.
src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py Adds unit tests for the new context getters and decorator mutators.
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Adds scenario tests for create/update and approuting flows involving App Routing Istio.

@jaiveerk jaiveerk changed the title [DRAFT] Adding CLI Implementation for App Routing Istio Adding CLI Implementation for App Routing Istio Mar 11, 2026
short-summary: Enable managed installation of Gateway API CRDs from the standard release channel.
- name: --enable-app-routing-istio --enable-ari
type: bool
short-summary: Enable Istio in App Routing for Gateway API based ingress only without service mesh functionality.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
short-summary: Enable Istio in App Routing for Gateway API based ingress only without service mesh functionality.
short-summary: Enable App Routing for Gateway API via Istio for Gateway API-based ingress traffic management only, without service mesh functionality.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more wordy, what value does this addition add? Do you not like the istio in part?

Copy link
Contributor Author

@jaiveerk jaiveerk Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

Enable Gateway API based ingress on App Routing via Istio without service mesh functionality

FumingZhang
FumingZhang previously approved these changes Mar 12, 2026
@FumingZhang
Copy link
Member

The live test passed!

  • test_aks_create_and_update_with_app_routing_istio
  • test_aks_create_with_app_routing_istio_fails_when_asm_enabled
  • test_aks_update_app_routing_istio_fails_when_asm_enabled
  • test_aks_update_switch_from_asm_to_app_routing_istio_fails
  • test_aks_update_switch_from_app_routing_istio_to_asm_fails
  • test_aks_approuting_gateway_istio_enable_disable

@jaiveerk
Copy link
Contributor Author

@FumingZhang / @yanzhudd can we get this merged if all looks good? would love to get this into cx hands asap. Thanks!

@yanzhudd
Copy link
Contributor

please resolve the code conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants