Adding CLI Implementation for App Routing Istio#9669
Adding CLI Implementation for App Routing Istio#9669jaiveerk wants to merge 10 commits intoAzure:mainfrom
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks approuting gateway | sub group aks approuting gateway added |
||
| aks create | cmd aks create added parameter enable_app_routing_istio |
||
| aks update | cmd aks update added parameter disable_app_routing_istio |
||
| aks update | cmd aks update added parameter enable_app_routing_istio |
|
Hi @jaiveerk, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @jaiveerk Release SuggestionsModule: aks-preview
Notes
|
There was a problem hiding this comment.
Pull request overview
This PR adds CLI support in aks-preview for configuring “App Routing Istio” (Istio as a Gateway API implementation for App Routing) across az aks create, az aks update, and a new az aks approuting gateway istio command group.
Changes:
- Add new CLI flags
--enable-app-routing-istio/--enable-ari(create/update) and--disable-app-routing-istio/--disable-ari(update). - Add new approuting subcommands:
az aks approuting gateway istio enable|disable. - Wire the new flags into the managed cluster decorator and add unit + scenario test coverage.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/managed_cluster_decorator.py | Adds context getters and create/update mutators to set App Routing Istio mode under ingress profile. |
| src/aks-preview/azext_aks_preview/custom.py | Adds approuting “gateway istio” enable/disable custom commands and plumbs update flow. |
| src/aks-preview/azext_aks_preview/commands.py | Registers the new aks approuting gateway istio command group. |
| src/aks-preview/azext_aks_preview/_params.py | Adds new CLI parameters and aliases for create/update. |
| src/aks-preview/azext_aks_preview/_help.py | Documents new flags and the new approuting command group. |
| src/aks-preview/azext_aks_preview/_consts.py | Adds string constants for the new Istio mode values. |
| src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py | Adds unit tests for the new context getters and decorator mutators. |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Adds scenario tests for create/update and approuting flows involving App Routing Istio. |
| short-summary: Enable managed installation of Gateway API CRDs from the standard release channel. | ||
| - name: --enable-app-routing-istio --enable-ari | ||
| type: bool | ||
| short-summary: Enable Istio in App Routing for Gateway API based ingress only without service mesh functionality. |
There was a problem hiding this comment.
| short-summary: Enable Istio in App Routing for Gateway API based ingress only without service mesh functionality. | |
| short-summary: Enable App Routing for Gateway API via Istio for Gateway API-based ingress traffic management only, without service mesh functionality. |
There was a problem hiding this comment.
This is more wordy, what value does this addition add? Do you not like the istio in part?
There was a problem hiding this comment.
How about
Enable Gateway API based ingress on App Routing via Istio without service mesh functionality
|
The live test passed!
|
|
@FumingZhang / @yanzhudd can we get this merged if all looks good? would love to get this into cx hands asap. Thanks! |
|
please resolve the code conflicts |
cfb417d to
2f6f508
Compare
Adding app routing istio flags/commands.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create
az aks update
az aks approuting
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.