Fix preview check to match Azure Marketplace conventions

[Copilot]

• Understand the issue: offer names can contain 'preview' but only those ending with 'preview' are actual preview offerings
• Fix the test logic to check if offer ends with 'preview' instead of contains 'preview' anywhere
• Create test case to validate offers with 'preview' in name but not ending with it (should pass)
• Update existing fail test case to end with '-preview'
• Verify all test cases work correctly
• Address feedback: Changed offer pattern from '*-preview' to '*preview' (no hyphen required)
• Update test examples to use generic offer names instead of vendor-specific names
• Run code review (no issues found)
• Run security scan (no vulnerabilities detected)
• Complete task

Original prompt

---

This section details on the original issue you should resolve

<issue_title>False Failure for "Virtual Machines Should Not Be Preview"</issue_title>
<issue_description>The check for "Virtual Machines Should Not Be Preview" checks if the word preview is anywhere in the offer name which isn't how previews work. Preview offers only end with -preview but are allowed to have preview in the offer name itself. For example: https://marketplace.microsoft.com/en-us/product/trendmicro.zero-trust-secure-access-preview-st is not a preview offering.

Commit 1b69a9b added this breaking change.

This breaking change is causing us certification issues when attempting to update our marketplace offering.</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes False Failure for "Virtual Machines Should Not Be Preview" #793

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[psah434]

@copilot change the check for offer from -preview to just preview.

[psah434]

@copilot in the examples please remove the offer value to be something more random.

[Copilot]

@copilot change the check for offer from -preview to just preview.

Changed the offer check from *-preview to *preview as requested. The pattern now matches offers ending with "preview" (with or without a hyphen). All test cases still pass correctly. Commit: 9be57ca

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• aka.ms
  • Triggering command: /usr/bin/pwsh pwsh -Command Import-Module ./arm-ttk/arm-ttk.psd1 -Force Write-Host 'Testing offer with preview in middle: zero-trust-secure-access-preview-st' $result = Test-AzTemplate -TemplatePath ./unit-tests/Virtual-Machines-Should-Not-Be-Preview/Pass/offer-with-preview-in-name (dns block)
  • Triggering command: /usr/bin/pwsh pwsh -Command Import-Module ./arm-ttk/arm-ttk.psd1 -Force Write-Host 'Testing Pass cases...' Get-ChildItem ./unit-tests/Virtual-Machines-Should-Not-Be-Preview/Pass/*.json | ForEach-Object { Write-Host "Testing $($_.Name)..." $result = Test-AzTemplate -Template (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

@copilot in the examples please remove the offer value to be something more random.

Updated test examples to use generic offer names:

• Pass case: product-preview-edition (has "preview" in middle, not a preview offering)
• Fail case: test-offer-preview (ends with "preview", is a preview offering)

Both use generic TestPublisher instead of vendor-specific names. Commit: 45da707

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• aka.ms
  • Triggering command: /usr/bin/pwsh pwsh -Command Import-Module ./arm-ttk/arm-ttk.psd1 -Force Write-Host 'Testing Pass case: product-preview-edition (preview in middle)' $result = Test-AzTemplate -TemplatePath ./unit-tests/Virtual-Machines-Should-Not-Be-Preview/Pass/offer-with-preview-in-name.json -Test (dns block)
  • Triggering command: /usr/bin/pwsh pwsh -Command Import-Module ./arm-ttk/arm-ttk.psd1 -Force Write-Host 'Running all Virtual Machines Should Not Be Preview tests...' Write-Host '' Write-Host 'Pass cases:' Get-ChildItem ./unit-tests/Virtual-Machines-Should-Not-Be-Preview/Pass/*.json | ForEach-Object { (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)