fix: better error message in windows CSE when API server can't be contacted#7828
Open
timmy-wright wants to merge 5 commits intomainfrom
Open
fix: better error message in windows CSE when API server can't be contacted#7828timmy-wright wants to merge 5 commits intomainfrom
timmy-wright wants to merge 5 commits intomainfrom
Conversation
timmy-wright
requested review from
AbelHu,
Devinwong,
YaoC,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
yagmurbaydogan,
yewmsft and
zachary-bailey
as code owners
timmy-wright
force-pushed
the
timmy/better-error
branch
from
cbe6b64 to
d426ca1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Linux VHD/provisioning artifacts, SIG image version pinning, and CI pipelines (including E2E auth) alongside regenerating snapshot testdata.
Changes:
- Freeze MarinerV2/AzureLinuxV2 SIG image version and update related tests/testdata.
- Add disk queue tuning script/service and corresponding E2E validations.
- Switch CI tasks to
AzureCLI@2and update E2E auth to use Azure CLI credentials.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/agent/testdata/AKSUbuntu2204+CustomCloud/CustomData | Regenerated snapshot CustomData payloads. |
| pkg/agent/testdata/AKSUbuntu2204+China/CustomData | Regenerated snapshot CustomData payloads. |
| pkg/agent/datamodel/sig_config_test.go | Update expected SIG version constant for frozen V2 images. |
| pkg/agent/datamodel/sig_config.go | Introduce frozen V2 SIG image version constant and apply it to templates. |
| pkg/agent/datamodel/osimageconfig.go | Adjust cloud-to-image mapping (new cloud entry + key fixes). |
| pkg/agent/datamodel/linux_sig_version.json | Bump linux SIG version value to 202512.06.0. |
| parts/linux/cloud-init/artifacts/ubuntu/cse_install_ubuntu.sh | Remove NVIDIA repo cleanup call from GPU cleanup path. |
| parts/linux/cloud-init/artifacts/ubuntu/cse_helpers_ubuntu.sh | Add apt-get clean after successful installs. |
| parts/linux/cloud-init/artifacts/mariner/cse_install_mariner.sh | Remove NVIDIA repo cleanup call from GPU cleanup path. |
| parts/linux/cloud-init/artifacts/disk_queue.sh | Add disk queue tuning script selecting Azure root/os device link. |
| parts/linux/cloud-init/artifacts/disk_queue.service | Update ExecStart to run the new disk_queue.sh script. |
| parts/linux/cloud-init/artifacts/cse_config.sh | Remove NVIDIA repo cleanup after GPU driver installation. |
| parts/common/components.json | Update multiple component versions and one download location path. |
| packer.mk | Remove az-login logic; target now only sets subscription. |
| e2e/validators.go | Add validators for aks-log-collector and disk_queue.service. |
| e2e/validation.go | Call new validators from common Linux validation suite. |
| e2e/scenario_test.go | Change secure TLS bootstrapping failure setup to use invalid user-assigned identity. |
| e2e/config/azure.go | Switch to Azure CLI credential for ARM clients. |
| .pipelines/templates/e2e-template.yaml | Run E2E scripts via AzureCLI@2 task. |
| .pipelines/templates/.builder-release-template.yaml | Wrap builder steps with AzureCLI@2. |
| .pipelines/templates/.builder-release-template-windows.yaml | Wrap Windows builder steps with AzureCLI@2 and tweak conditions. |
| .pipelines/templates/.build-and-test-windows-vhds-template.yaml | Run cleanup via AzureCLI@2. |
| .pipelines/scripts/windows_build_vhd.sh | Remove explicit make ... az-login invocation. |
| .pipelines/scripts/windows-sub-cleanup.sh | Remove explicit make ... az-login invocation. |
| .pipelines/scripts/e2e_run.sh | Remove managed identity login step; rely on Azure CLI session. |
| .pipelines/.vsts-vhd-builder-release.yaml | Disable MarinerV2/AzureLinuxV2 builds by default. |
| .pipelines/.vsts-vhd-builder-pr-windows.yaml | Run windows sub cleanup via AzureCLI@2. |
| .pipelines/.vsts-garabge-collection.yaml | Run GC script via AzureCLI@2. |
| .github/workflows/pr-lint.yaml | Trigger PR lint workflow on synchronize events. |
timmy-wright
changed the title
djsly
approved these changes
Feb 10, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Better error message when API server can't be contacted
Which issue(s) this PR fixes:
Fixes #