fix: stringify all bigints in pino-logger #20303
Open
+117
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spypsy
force-pushed
the
spy/pino-bigints
branch
from
bae35a3 to
30fedcf
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
PhilWindle
reviewed
Feb 11, 2026
| /** | ||
| * Converts bigint values to strings recursively in a log object to avoid serialization issues. | ||
| */ | ||
| function convertBigintsToStrings(obj: unknown): unknown { |
Collaborator
There was a problem hiding this comment.
Can this reuse the other convert function?
Member
Author
There was a problem hiding this comment.
yeah definitely an oversight here.. They should be using the same
| /** | ||
| * Converts bigint values to strings recursively in a log object to avoid serialization issues. | ||
| */ | ||
| function convertBigintsToStrings(obj: unknown): unknown { |
Collaborator
There was a problem hiding this comment.
Do we have to use unknowns here?
Member
Author
There was a problem hiding this comment.
because this is used for logging I don't think there's much point typing this. It can be pretty much anything and result also depends on input so using unknown is safer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes A-495